public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900
@ 2012-10-14 10:04 Ивайло Димитров
  0 siblings, 0 replies; 9+ messages in thread
From: Ивайло Димитров @ 2012-10-14 10:04 UTC (permalink / raw)
  To: u-boot

 Hi Marek,

as part of the code is written by me I will answer to a couple of the questions


 >Dear Pali Roh?r,
 >
 >> Based on previous work by: Alistair Buxton 
 >> 
 >> Signed-off-by: Pali Roh?r 
 >> Cc: ?????? ???????? 
 >
 >Can we please stick to ASCII instead of UTF8?
 >
 >Cc: Ivaylo Dimitrov (if I'm not mistaken)

You are not :). And if it comes to me, it does not matter whether cyrillic or latin will be used.

 >> +}
 >> +
 >> +static void omap3_emu_romcode_call(u32 service_id, u32 *parameters)
 >> +{
 >> +	u32 i, num_params = *parameters;
 >> +	u32 *sram_scratch_space = (u32 *)OMAP3_PUBLIC_SRAM_SCRATCH_AREA;
 >> +
 >> +	/*
 >> +	 * copy the parameters to an un-cached area to avoid coherency
 >> +	 * issues
 >> +	 */
 >
 >_WHAT_ ?!
 >
 >Use dcache_flush(). The Omap3 rom won't cope with cache memory? Actually -- why 
 >do you even do call into ROM ?
 >
 >> +	for (i = 0; i < num_params; i++) {
 >> +		__raw_writel(*parameters, sram_scratch_space);
 >> +		parameters++;
 >> +		sram_scratch_space++;
 >> +	}
 >> +
 >> +	/* Now make the PPA call */
 >> +	do_omap3_emu_romcode_call(service_id, OMAP3_PUBLIC_SRAM_SCRATCH_AREA);
 >> +}
 >> +

That part of the code is ported from existing code in u-boot:
http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/omap3/board.c;h=9cee1d9b490692d02129d98470ba7b57b8e61ce2;hb=HEAD#l373

So I can't think of a reason to do it in a different way.

The ROM call is needed to enable workaround for ARM errata 430973. RX-51 being a high secure device does not allow writes to AUX control register outside of the secure world. So, this call is needed to enable IBE bit in AUXCR. I can elaborate more if needed.

 >> +	 * Cortex-A8(r1p0..r1p2) errata 430973 workaround
 >> +	 * Set IBE bit in Auxiliary Control Register
 >> +	 */
 >> +	omap3_update_aux_cr_secure_rx51(1 << 6, 0);
 >> +
 >> +	return 0;
 >> +}
 >> +
 >

And here is the code where IBE bit (bit 6) set.

Have in mind there is a difference re how parameters are passed compared to beagleboard for example, RX-51 ROM expects first parameter to be the number of remaining parameters+1, while beagleboard(again, just an example) ROM expects only the number of the remaining parameters, so existing function in arch/arm/cpu/armv7/omap3/board.c cannot be called (even if it is not declared static).

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 00/14] Nokia RX-51 support
@ 2012-01-24 14:27 Pali Rohár
  2012-10-13 19:31 ` [U-Boot] [PATCH v3 0/5] " Pali Rohár
  0 siblings, 1 reply; 9+ messages in thread
From: Pali Rohár @ 2012-01-24 14:27 UTC (permalink / raw)
  To: u-boot

This patch series add support for new board Nokia RX-51 (aka N900).
Last two patches adding on screen bootmenu support.

This series supersedes the last sent version.

Pali Roh?r (14):
  arm,omap3: Define save_boot_params in lowlevel_init.S for SPL only
  arm: Optionally use existing atags in bootm.c
  Add power bus message definitions in twl4030.h
  Fix function readline in main.c
  cfb_console: Fix function console_scrollup
  cfb_console: Add function console_clear and console_clear_line
  cfb_console: Add functions for moving with cursor
  cfb_console: Add support for some ANSI terminal escape codes
  New command clear: Clear the ANSI terminal
  New config variable CONFIG_MENUCMD
  New config variable CONFIG_PREMONITOR
  New board support: Nokia RX-51 aka N900
  New command bootmenu: ANSI terminal Boot Menu support
  RX-51: Add support for bootmenu

 README                                   |    2 +
 arch/arm/cpu/armv7/omap3/lowlevel_init.S |    4 +-
 arch/arm/lib/bootm.c                     |   39 +++-
 board/nokia/rx51/Makefile                |   46 ++++
 board/nokia/rx51/lowlevel_init.S         |   79 ++++++
 board/nokia/rx51/rx51.c                  |  381 ++++++++++++++++++++++++++++++
 board/nokia/rx51/rx51.h                  |  378 +++++++++++++++++++++++++++++
 boards.cfg                               |    1 +
 common/Makefile                          |    2 +
 common/cmd_bootmenu.c                    |  366 ++++++++++++++++++++++++++++
 common/cmd_clear.c                       |   42 ++++
 common/env_common.c                      |    3 +
 common/main.c                            |   89 ++++++-
 drivers/video/cfb_console.c              |  346 +++++++++++++++++++++++++--
 include/common.h                         |   20 ++
 include/config_cmd_all.h                 |    2 +
 include/configs/nokia_rx51.h             |  375 +++++++++++++++++++++++++++++
 include/twl4030.h                        |   98 ++++++++
 18 files changed, 2233 insertions(+), 40 deletions(-)
 create mode 100644 board/nokia/rx51/Makefile
 create mode 100644 board/nokia/rx51/lowlevel_init.S
 create mode 100644 board/nokia/rx51/rx51.c
 create mode 100644 board/nokia/rx51/rx51.h
 create mode 100644 common/cmd_bootmenu.c
 create mode 100644 common/cmd_clear.c
 create mode 100644 include/configs/nokia_rx51.h

-- 
1.7.5.4

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2012-10-16 16:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-14 10:04 [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900 Ивайло Димитров
  -- strict thread matches above, loose matches on Subject: below --
2012-01-24 14:27 [U-Boot] [PATCH 00/14] Nokia RX-51 support Pali Rohár
2012-10-13 19:31 ` [U-Boot] [PATCH v3 0/5] " Pali Rohár
2012-10-13 19:32   ` [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900 Pali Rohár
2012-10-14  0:06     ` Marek Vasut
2012-10-14  8:31       ` Albert ARIBAUD
2012-10-16 14:43       ` Pali Rohár
2012-10-16 14:55         ` Marek Vasut
2012-10-16 15:46           ` Pali Rohár
2012-10-16 15:57             ` Marek Vasut
2012-10-16 16:15               ` Pali Rohár

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox