[U-Boot-Users] [PATCH] fix comment in net.c

Pantelis Antoniou
2005-11-10T07:56:53Z

Ron Alder wrote:
> This patch fixes a comment in net/net.c
>
> CHANGELOG:
> * Fix comment in net/net.c
> Patch by Ron Alder, 09 Nov 2005
>
>
> ------------------------------------------------------------------------
>
> diff --git a/net/net.c b/net/net.c
> --- a/net/net.c
> +++ b/net/net.c
> @@ -829,7 +829,6 @@ static ushort CDP_compute_csum(const uch
> }
> if (len) {
> leftover = (signed short)(*(const signed char *)buff);
> - /* * XXX CISCO SUCKS big time! (and blows too) */
> result = (result & 0xffff0000) | ((result + leftover) & 0x0000ffff);
> }
> while (result >> 16)

WTF is this? Politically correct day?

Since I wrote the comment in question let me elaborate.

CDP uses the ip checksum algorithm with a twist; for the last
byte it *sign* extends and sums. Obviously this is is completely
braindead, and warants the comment and much more :)

Regards

Pantelis