From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pantelis Antoniou <panto@intracom.gr>
Date: Thu, 10 Nov 2005 09:56:53 +0200
Subject: [U-Boot-Users] [PATCH] fix comment in net.c
In-Reply-To: <4372896E.9080204@freescale.com>
References: <4372896E.9080204@freescale.com>
Message-ID: <4372FD45.8080807@intracom.gr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Ron Alder wrote:
> This patch fixes a comment in net/net.c
> 
> CHANGELOG:
> * Fix comment in net/net.c
>  Patch by Ron Alder, 09 Nov 2005
> 
> 
> ------------------------------------------------------------------------
> 
> diff --git a/net/net.c b/net/net.c
> --- a/net/net.c
> +++ b/net/net.c
> @@ -829,7 +829,6 @@ static ushort CDP_compute_csum(const uch
>  		}
>  		if (len) {
>  			leftover = (signed short)(*(const signed char *)buff);
> -			/* * XXX CISCO SUCKS big time! (and blows too) */
>  			result = (result & 0xffff0000) | ((result + leftover) & 0x0000ffff);
>  		}
>  		while (result >> 16)

WTF is this? Politically correct day?

Since I wrote the comment in question let me elaborate.

CDP uses the ip checksum algorithm with a twist; for the last
byte it *sign* extends and sums. Obviously this is is completely
braindead, and warants the comment and much more :)

Regards

Pantelis