AW: [U-Boot-Users] [PATCH] fix comment in net.c

AW: [U-Boot-Users] [PATCH] fix comment in net.c

[Jonas Mark *]

Good morning Pantelis,

> Ron Alder wrote:
>> This patch fixes a comment in net/net.c
>> 
>> CHANGELOG:
>> * Fix comment in net/net.c
>>  Patch by Ron Alder, 09 Nov 2005
>> 
>> 
>>
------------------------------------------------------------------------
>> 
>> diff --git a/net/net.c b/net/net.c
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -829,7 +829,6 @@ static ushort CDP_compute_csum(const uch
}
>>  		if (len) {
>>  			leftover = (signed short)(*(const signed char
*)buff);
>> -			/* * XXX CISCO SUCKS big time! (and blows too)
*/
>>  			result = (result & 0xffff0000) | ((result +
leftover) &
>>  		0x0000ffff);  		} while (result >> 16)
> 
> WTF is this? Politically correct day?

I've been with Motorola and Freescale and indeed political correctness
is
a high value there.

> Since I wrote the comment in question let me elaborate.
> 
> CDP uses the ip checksum algorithm with a twist; for the last
> byte it *sign* extends and sums. Obviously this is is completely
> braindead, and warants the comment and much more :)

I agree with you that removing your comment does not yield any real
benefit -
except maybe for the people working at Cisco. But I guess you agree that
instead of insulting people a comment that elaborates why you were
forced to
do what you did would have been much better.

> Regards
> 
> Pantelis

Regards
Mark

AW: [U-Boot-Users] [PATCH] fix comment in net.c

[Pantelis Antoniou]

Jonas Mark (ST-FIR/ENG1) * wrote:
> Good morning Pantelis,
> 
> 
>>Ron Alder wrote:
>>
>>>This patch fixes a comment in net/net.c
>>>
>>>CHANGELOG:
>>>* Fix comment in net/net.c
>>> Patch by Ron Alder, 09 Nov 2005
>>>
>>>
>>>
> 
> ------------------------------------------------------------------------
> 
>>>diff --git a/net/net.c b/net/net.c
>>>--- a/net/net.c
>>>+++ b/net/net.c
>>>@@ -829,7 +829,6 @@ static ushort CDP_compute_csum(const uch
> 
> }
> 
>>> 		if (len) {
>>> 			leftover = (signed short)(*(const signed char
> 
> *)buff);
> 
>>>-			/* * XXX CISCO SUCKS big time! (and blows too)
> 
> */
> 
>>> 			result = (result & 0xffff0000) | ((result +
> 
> leftover) &
> 
>>> 		0x0000ffff);  		} while (result >> 16)
>>
>>WTF is this? Politically correct day?
> 
> 
> I've been with Motorola and Freescale and indeed political correctness
> is
> a high value there.
> 
> 
>>Since I wrote the comment in question let me elaborate.
>>
>>CDP uses the ip checksum algorithm with a twist; for the last
>>byte it *sign* extends and sums. Obviously this is is completely
>>braindead, and warants the comment and much more :)
> 
> 
> I agree with you that removing your comment does not yield any real
> benefit -
> except maybe for the people working at Cisco. But I guess you agree that
> instead of insulting people a comment that elaborates why you were
> forced to
> do what you did would have been much better.
>

Obviously the comment is tonque-in-cheek. I don't know if any cisco
engineers are on this list, but if they are, guys I meant no harm :).

However, I take offence at the politically correct presure on people.

Open source software is done for fun at heart, and having to cowtow to
every person's definition of offensive will take the fun away.

If people are so  much offended by a simple innocuous comment, I suggest
that they pick up a job at a church or a madrassa...

Regards

Pantelis

PS. Think of the children!