U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Przywara" <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [linux-sunxi] [PATCH] Revert "sunxi: board: Print error after power initialization fails"
Date: Wed, 19 Dec 2018 00:51:17 +0000	[thread overview]
Message-ID: <437960cd-25c0-baad-5265-cd0db1dcbd2f@arm.com> (raw)
In-Reply-To: <CAMty3ZDHPAoYR8nV8w_OSDMcw43MveHYOvfUp5i2FDrFAdxcyw@mail.gmail.com>

On 18/12/2018 12:06, Jagan Teki wrote:
> On Tue, Dec 18, 2018 at 4:09 PM <karlp@tweak.net.au> wrote:
>>
>> From: Karl Palsson <karlp@tweak.net.au>
>>
>> This reverts commit a8011eb84dfac5187cebf00ed8bc981bdb5c1fa1
>>
>> This causes DRAM init failures on (at least)
>> * allwinner h3 nanopi-duo2
>> * allwinner h2+ orangepi zero v1.1
>>
>> Signed-off-by: Karl Palsson <karlp@tweak.net.au>
>> ---
>>
>> Ideally, this should get into 2019.01, so that this release is not
>> broken on those targets.
> 
> Better to understand the issue here, since I have BPI-M2+ which boots
> fine w/o this revert.

Could this be a .bss issue? This lies in DRAM and is thus only available
*after* DRAM init. IIRC we silently rely on not accessing anything in
.bss before the DRAM is up, see 59d07ee08e85 for instance.
I don't immediately spot any .bss usage in clock_set_pll1(), though.

Or is the 1GHz CPU clock speed too fast for the DRAM init? If I am not
mistaken, we run with 24MHz before, so there might be some "natural"
delay in some setup routines. Some DRAM chips or board layout might be
more susceptible to this than others, which might explain why it only
fails on some boards.

So if the original patch is about bailing out on error early, can't we
just do *that* before the DRAM init, keeping the CPU clock setup still
after DRAM?

Cheers,
Andre.

  parent reply	other threads:[~2018-12-19  0:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 10:38 [U-Boot] [PATCH] Revert "sunxi: board: Print error after power initialization fails" karlp at tweak.net.au
2018-12-18 12:06 ` [U-Boot] [linux-sunxi] " Jagan Teki
2018-12-18 12:30   ` Karl Palsson
2018-12-18 12:38     ` Jagan Teki
2018-12-18 12:49       ` Karl Palsson
2018-12-18 20:17         ` Michael Nazzareno Trimarchi
2018-12-18 21:03           ` Karl Palsson
2018-12-18 21:09           ` Priit Laes
2018-12-19  0:51   ` André Przywara [this message]
2018-12-19  1:45     ` André Przywara
2018-12-19  8:29       ` Michael Nazzareno Trimarchi
2018-12-19  8:35       ` Priit Laes
  -- strict thread matches above, loose matches on Subject: below --
2018-12-19 13:00 [U-Boot] " Andre Przywara
2018-12-29 18:53 ` [U-Boot] [linux-sunxi] " Jagan Teki
2018-12-29 22:10   ` Olliver Schinagl
2018-12-30  4:28     ` Priit Laes
2018-12-30 23:23     ` André Przywara
2018-12-31 10:34       ` Olliver Schinagl
2018-12-31 11:27         ` Michael Trimarchi
2018-12-31 13:10           ` André Przywara
2018-12-31 13:38             ` Michael Trimarchi
2018-12-31 19:31             ` Olliver Schinagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437960cd-25c0-baad-5265-cd0db1dcbd2f@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox