[U-Boot-Users] Re: [PATCH] Make System IO Config Registers board configurable on MPC83xx

[U-Boot-Users] Re: [PATCH] Make System IO Config Registers board configurable on MPC83xx

[David Updegraff]

Kumar

Now I wonder if a similar thing might be done in start.S, so that the 
[re] mapped size of flash complies with what is defined in the config 
file?  Either from flash size, or from the _PRELIM_* settings that are 
already there?  Instead of current status quo of hardwired to 8M flash size?


> Make System IO Config Registers board configurable on MPC83xx
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> 
> CHANGELOG:
> * Make System IO Config Registers board configurable on MPC83xx
>   Patch by Kumar Gala 23 Nov 2005
> 
> ---
> commit 01b445b70c5e296c115b93a894ff3c7ffc1586d5
> tree 2a2398b1bd34aa9b79e7ba34b4ccf7c28c932734
> parent f6a259d086597f691d821a5ac2181ce249fad987
> author Kumar Gala <galak@kernel.crashing.org> Wed, 23 Nov 2005 14:31:37 -0600
> committer Kumar Gala <galak@kernel.crashing.org> Wed, 23 Nov 2005 14:31:37 -0600
> 
>  cpu/mpc83xx/cpu_init.c       |    8 ++++++--
>  include/configs/MPC8349ADS.h |    4 ++++
>  include/configs/TQM834x.h    |    4 ++++
>  3 files changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c
> index dcb3445..e75b8b7 100644
> --- a/cpu/mpc83xx/cpu_init.c
> +++ b/cpu/mpc83xx/cpu_init.c
> @@ -63,8 +63,12 @@ void cpu_init_f (volatile immap_t * im)
>  	im->sysconf.spcr |= SPCR_TBEN;
>  
>  	/* System General Purpose Register */
> -	im->sysconf.sicrh = SICRH_TSOBI1;
> -	im->sysconf.sicrl = SICRL_LDP_A;
> +#ifdef CFG_SICRH
> +	im->sysconf.sicrh = CFG_SICRH;
> +#endif
> +#ifdef CFG_SICRL
> +	im->sysconf.sicrl = CFG_SICRL;
> +#endif
>  
>  	/*
>  	 * Memory Controller:
> diff --git a/include/configs/MPC8349ADS.h b/include/configs/MPC8349ADS.h
> index 41309ac..7197e0f 100644
> --- a/include/configs/MPC8349ADS.h
> +++ b/include/configs/MPC8349ADS.h
> @@ -504,6 +504,10 @@
>  	HRCWH_TSEC2M_IN_GMII )
>  #endif
>  
> +/* System IO Config */
> +#define CFG_SICRH	SICRH_TSOBI1
> +#define CFG_SICRL	SICRL_LDP_A
> +
>  #define CFG_HID0_INIT 0x000000000
>  
>  #define CFG_HID0_FINAL CFG_HID0_INIT
> diff --git a/include/configs/TQM834x.h b/include/configs/TQM834x.h
> index c25a777..a2184ee 100644
> --- a/include/configs/TQM834x.h
> +++ b/include/configs/TQM834x.h
> @@ -417,6 +417,10 @@ extern int tqm834x_num_flash_banks;
>  	HRCWH_TSEC2M_IN_GMII )
>  #endif
>  
> +/* System IO Config */
> +#define CFG_SICRH	SICRH_TSOBI1
> +#define CFG_SICRL	SICRL_LDP_A
> +
>  /* i-cache and d-cache disabled */
>  #define CFG_HID0_INIT		0x000000000
>  #define CFG_HID0_FINAL		CFG_HID0_INIT
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

[U-Boot-Users] Re: [PATCH] Make System IO Config Registers board configurable on MPC83xx

[Wolfgang Denk]

In message <dm2kgr$u4s$1@sea.gmane.org> you wrote:
> 
> Now I wonder if a similar thing might be done in start.S, so that the 
> [re] mapped size of flash complies with what is defined in the config 
> file?  Either from flash size, or from the _PRELIM_* settings that are 
> already there?  Instead of current status quo of hardwired to 8M flash size?

start.S is definitely not the place  for  (re)mapping  flash.  Please
read  the README. Only after relocation to RAM the flash seize can be
determined, and only then the final mapping can be set up. Just  like
it is done now - at list in all sane ports.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Data is a lot like humans: It is  born.  Matures.  Gets  married  to
other  data, divorced. Gets old. One thing that it doesn't do is die.
It has to be killed."                                 - Arthur Miller

[U-Boot-Users] Re: [PATCH] Make System IO Config Registers board configurable on MPC83xx

[David Updegraff]

Wolfgang.

That is very  convincing. So for the special case of setting RCW to boot 
from lowmem vector, all is well.  And I guess there is no great harm in 
that restriction.

When RCW set to boot from himem vector though, the 83xx maps in the 
_last_ 8M of the flash chip, not the first, so the remap_flash_by_law* 
routines end up mapping u-boot out from under us.  But OK; we just won't 
do that then.

I still stand by by compaint though: if you're going to remap flash 
according to CFG_FLASH_BASE in start.S,  then the 8M hardcoded size is 
annoying.

>>back to LAW0 on a builtin assumption of 8M size, placing the starting 
>>address thereof to the CFG_FLASH_BASE location (in their case, 
>>0xfe00_0000); then do jumping arithmetic based on that value and TEXT_BASE.
>>
>>Which works in the Freescale-ADS case, as they have an 8M flash chip.
> 
> 
> It also works in case of the TQM8349 board, which uses 32 MB:
> 
> U-Boot 1.1.4 (Nov 17 2005 - 00:14:36) MPC83XX
> 
> Clock configuration:
>   Coherent System Bus:  266 MHz
>   Core:                 533 MHz
>   Local Bus:             33 MHz
> CPU:   MPC83xx, Rev: 1.1 at 533.328 MHz
> Board: TQM834x
> PCI1:  32 bit, 33 MHz
> I2C:   ready
> DTT:   1 is 28 C
> DRAM:  256 MB
> FLASH: 32 MB
> PCI:   Bus Dev VenId DevId Class Int
> In:    serial
> Out:   serial
> Err:   serial
> Net:   TSEC0, TSEC1
> 
> Type "run flash_nfs" to mount root filesystem over NFS
> 
> Hit any key to stop autoboot:  0 
> => fli
> 
> Bank # 1: CFI conformant FLASH (32 x 16)  Size: 32 MB in 256 Sectors
>  Erase timeout 16384 ms, write timeout 0 ms, buffer write timeout 4096 ms, buffer size 32
>   Sector Start Addresses:
>     80000000 (RO) 80020000 (RO) 80040000 (RO) 80060000      80080000     
>     800A0000      800C0000      800E0000      80100000      80120000     
>     80140000      80160000      80180000      801A0000      801C0000     
> ...
> 
> Best regards,
> 
> Wolfgang Denk
> 

[U-Boot-Users] Re: [PATCH] Make System IO Config Registers board configurable on MPC83xx

[Wolfgang Denk]

In message <Pine.LNX.4.44.0511231430380.6402-100000@gate.crashing.org> you wrote:
> 
> CHANGELOG:
> * Make System IO Config Registers board configurable on MPC83xx
>   Patch by Kumar Gala 23 Nov 2005

Dropped because I'll rather pull from your git repo. Thanks.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"When people are least sure, they are often most dogmatic."
- John Kenneth Galbraith