From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] PPC405EP CPC0_PCI init vs. update
Date: Tue, 06 Dec 2005 07:45:10 -0500 [thread overview]
Message-ID: <439587D6.4010902@psyent.com> (raw)
Hi All,
In cpu/ppc4xx/start.S, the CPC0_PCI register is _initialized_,
rather than being simply _updated_. This clears bits that are
set during bootstrap from a serial eeprom. E.g. for the
PerWE/PCI_INT mux, CPC0_PCI[SPE] always gets cleared.
I'm proposing a simple change and would like some feedback ...
it's not clear to me if this will cause problems for existing
boards.
Comments welcome :-)
Regards,
--Scott
===============================================================
--- a/cpu/ppc4xx/start.S
+++ b/cpu/ppc4xx/start.S
@@ -1539,7 +1539,8 @@ ppc405ep_init:
mtdcr ebccfgd,r3
#endif
- addi r3,0,CPC0_PCI_HOST_CFG_EN
+ mfdcr r3, CPC0_PCI
+ ori r3,r3,CPC0_PCI_HOST_CFG_EN
#ifdef CONFIG_BUBINGA
/*
!-----------------------------------------------------------------------
next reply other threads:[~2005-12-06 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 12:45 Scott McNutt [this message]
2005-12-06 16:05 ` [U-Boot-Users] PPC405EP CPC0_PCI init vs. update Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439587D6.4010902@psyent.com \
--to=smcnutt@psyent.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox