From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] mmc: fsl_esdhc_imx: add extra delay for IO voltage switch if necessary
Date: Mon, 22 Mar 2021 08:48:08 -0400 [thread overview]
Message-ID: <439d23b8-7e9c-e74d-aea9-853b33a3425d@gmail.com> (raw)
In-Reply-To: <CAOMZO5BEMhHDT-cqgVmWK+JK2=DFbjjKuEu7-kJmi=A1T317tg@mail.gmail.com>
On 3/22/21 8:04 AM, Fabio Estevam wrote:
> Hi Haibo,
>
> On Mon, Mar 22, 2021 at 8:09 AM <haibo.chen@nxp.com> wrote:
>
>> --- a/arch/arm/dts/imx8mm-evk-u-boot.dtsi
>> +++ b/arch/arm/dts/imx8mm-evk-u-boot.dtsi
>> @@ -102,6 +102,7 @@
>> u-boot,dm-spl;
>> sd-uhs-sdr104;
>> sd-uhs-ddr50;
>> + fsl,signal-voltage-switch-extra-delay-ms = <8>;
>
> How does the Linux kernel deal with that?
>
> I don't see such property in the mainline kernel or in the NXP tree.
>
> I am concerned that we add a U-Boot specific here. Also, the fact that
> common code waits 10ms is a driver implementation detail, so not happy
> that such information needs to be passed in the U-Boot dts.
>
Typically they wait in the regulator. E.g. regulator-ramp-delay or
regulator-settling-time-us. There should be no need to wait in the MMC
driver.
--Sean
next prev parent reply other threads:[~2021-03-22 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 10:55 [PATCH 1/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code haibo.chen at nxp.com
2021-03-22 10:55 ` [PATCH 2/2] mmc: fsl_esdhc_imx: add extra delay for IO voltage switch if necessary haibo.chen at nxp.com
2021-03-22 12:04 ` Fabio Estevam
2021-03-22 12:48 ` Sean Anderson [this message]
2021-04-09 11:24 ` sbabic at denx.de
2021-04-09 11:24 ` [PATCH 1/2] mmc: fsl_esdhc_imx: remove redundant cmd11 related code sbabic at denx.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439d23b8-7e9c-e74d-aea9-853b33a3425d@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox