U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel.ziswiler@codethink.co.uk>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	Marek Vasut	 <marex@denx.de>,
	u-boot@lists.denx.de, Jonas Karlman <jonas@kwiboo.se>,
	Soeren Moch <smoch@web.de>
Cc: Tim Harvey <tharvey@gateworks.com>,
	Philipp Tomsich	 <philipp.tomsich@vrull.eu>,
	Anand Moon <linux.amoon@gmail.com>,
	Maxim Kiselev	 <bigunclemax@gmail.com>
Subject: Re: [PATCH v2 0/4] USB-PD TCPM improvements
Date: Wed, 18 Jun 2025 10:36:23 +0100	[thread overview]
Message-ID: <43d431db9b68b9fffff160abba13b894b2340ad4.camel@codethink.co.uk> (raw)
In-Reply-To: <20250226184506.64114-1-sebastian.reichel@collabora.com>

Hi folks

On Wed, 2025-02-26 at 19:44 +0100, Sebastian Reichel wrote:
> Hi,
> 
> I have a couple of fixes/improvements for the TCPM code. Three are fixing
> actual problems I noticed on the Rock 5B, which prevented booting up the
> system. One of them simply adds an error print before potentially committing
> hara-kiri by triggering a hard reset, which helps people understanding
> why their boards reset themself in case there are more problems. I've
> recently added the same print to the kernel TCPM code.

Thanks, any reason this series hasn't landed yet?

Anyway, I can confirm this tremendously improves the situation.

Whole series:

Tested-by: Marcel Ziswiler <marcel.ziswiler@codethink.co.uk> # rock5b

> Changes since PATCHv1:
>  * https://lore.kernel.org/u-boot/20241031175404.114773-5-sebastian.reichel@collabora.com/
>  * rebased to v2025.04-rc3 (no changes needed)
> 
> Greetings,
> 
> -- Sebastian
> 
> Sebastian Reichel (4):
>   usb: tcpm: improve handling of some power-supplies
>   usb: tcpm: avoid resets for missing source capability messages
>   usb: tcpm: print error on hard reset
>   usb: tcpm: improve data role mismatch error recovery
> 
>  drivers/usb/tcpm/tcpm-internal.h |  1 +
>  drivers/usb/tcpm/tcpm.c          | 95 ++++++++++++++++++++++++++++----
>  2 files changed, 85 insertions(+), 11 deletions(-)

Cheers

Marcel

      parent reply	other threads:[~2025-06-18  9:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 18:44 [PATCH v2 0/4] USB-PD TCPM improvements Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 1/4] usb: tcpm: improve handling of some power-supplies Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 2/4] usb: tcpm: avoid resets for missing source capability messages Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 3/4] usb: tcpm: print error on hard reset Sebastian Reichel
2025-02-26 18:44 ` [PATCH v2 4/4] usb: tcpm: improve data role mismatch error recovery Sebastian Reichel
2025-02-27  6:00 ` [PATCH v2 0/4] USB-PD TCPM improvements Anand Moon
2025-03-01 18:11   ` Peter Robinson
2025-03-03  7:38     ` Anand Moon
2025-03-03 16:06       ` Sebastian Reichel
2025-03-04  5:05         ` Anand Moon
2025-03-04 12:42           ` Sebastian Reichel
2025-03-04 14:50             ` Anand Moon
2025-03-06 19:00               ` Anand Moon
2025-03-07  9:29                 ` Soeren Moch
2025-03-27 17:08 ` Nicolas Frattaroli
2025-06-18  9:36 ` Marcel Ziswiler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43d431db9b68b9fffff160abba13b894b2340ad4.camel@codethink.co.uk \
    --to=marcel.ziswiler@codethink.co.uk \
    --cc=bigunclemax@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux.amoon@gmail.com \
    --cc=marex@denx.de \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sebastian.reichel@collabora.com \
    --cc=smoch@web.de \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox