[U-Boot-Users] [PATCH] CFI support for Versatile & Integrator/CP boards

Stefan Roese
2006-02-28T19:05:25Z

Hi Marcus,

On Tuesday, 28. February 2006 19:46, Marcus Hall wrote:
> > Could you and others (Marcus, Tolunay) please comment on what patch
> > should be applied here. I tend to take the patch from Marcus right now.
>
> Well, there are two variables here. I will abstract it to be
> Timeout :: flash_status_check returns != ERR_OK
> Fail :: status != FLASH_STATUS_DONE
> The following table should correspond to what gets returned by either
> code patch:
>
> Timeout Fail Marcus Peter
> 0 0 ERR_OK ERR_OK
> 0 1 ERR_INVAL ERR_INVAL
> 1 0 ERR_TIMEOUT ERR_INVAL
> 1 1 ERR_TIMEOUT ERR_INVAL
>
> Additionally, Peter's patch may output an additional error message after
> a timeout if it appears that some error flags are set (but they are not
> necessarily valid if the flash has timed out)
>
> So, I believe that either would work to ensure that if there is an error
> it does get reported, but I believe that my patch returns a more useful
> return code and doesn't output potentially confusing error messages.

Thanks for the detailed statement. Your (Marcus's) patch has been integrated.

Best regards,
Stefan