From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0329DC3601E for ; Tue, 8 Apr 2025 02:27:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 09D1782F63; Tue, 8 Apr 2025 04:27:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.b="aC4KgkV7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 45812812BC; Tue, 8 Apr 2025 04:27:23 +0200 (CEST) Received: from mail-m15594.qiye.163.com (mail-m15594.qiye.163.com [101.71.155.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B138C831A2 for ; Tue, 8 Apr 2025 04:27:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [192.168.60.65] (unknown [103.29.142.67]) by smtp.qiye.163.com (Hmail) with ESMTP id 10ff7e35f; Tue, 8 Apr 2025 10:27:15 +0800 (GMT+08:00) Message-ID: <441c1271-6c3f-4ece-82f5-d3ea0ebdf108@rock-chips.com> Date: Tue, 8 Apr 2025 10:27:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3066 To: Quentin Schulz , Simon Glass , Philipp Tomsich , Tom Rini Cc: Ilias Apalodimas , Jonas Karlman , Jagan Teki , u-boot@lists.denx.de, Quentin Schulz References: <20250129-rockchip-pinctrl-const-v1-0-450ccdadfa7e@cherry.de> <20250129-rockchip-pinctrl-const-v1-5-450ccdadfa7e@cherry.de> Content-Language: en-US From: Kever Yang In-Reply-To: <20250129-rockchip-pinctrl-const-v1-5-450ccdadfa7e@cherry.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVkZGUwdVkNNQkwdTh4dGk4dHVYVFAkWGhdVEwETFh oSFyQUDg9ZV1kYEgtZQVlKS0hVSUJVSk9JVU1MWVdZFhoPEhUdFFlBWU9LSFVKS0lPT09IVUpLS1 VKQktLWQY+ X-HM-Tid: 0a9613392b0d03afkunm10ff7e35f X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MAw6PBw6IjJID0NPD083AklW LUgwFBlVSlVKTE9PS0xCSUhMTUtCVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlKS0hVSUJVSk9JVU1MWVdZCAFZQUlLTkg3Bg++ DKIM-Signature: a=rsa-sha256; b=aC4KgkV7TB1sOCjBrDHRS6sKBnCHP+UIgslMB4xrEGHnj7j5Op7RmA0Q0MAwcfFiAor5hzLIgNvi6PvdT7FR/23NdBoAs3TZ9/wR5OKteqGazDTz2Wn8fGFkT6Wgk/ggbmbRqerUvF3BsOt3wf8BMi/0p70er9xaBXN8VXJxl0o=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=hpFipaGZaQhrlUwK7NELZKU9IbSh5+++wqpkIdh3jYo=; h=date:mime-version:subject:message-id:from; X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2025/1/29 20:42, Quentin Schulz wrote: > From: Quentin Schulz > > There's no need to modify private data from the controller, so let's > make that struct const. > > Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever > --- > drivers/pinctrl/rockchip/pinctrl-rk3066.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3066.c b/drivers/pinctrl/rockchip/pinctrl-rk3066.c > index 60e088a9a6f0d9133cd0822a9f4816cea18a524d..f773f2a3dab86dc866965cdcfd9b56da9e777acc 100644 > --- a/drivers/pinctrl/rockchip/pinctrl-rk3066.c > +++ b/drivers/pinctrl/rockchip/pinctrl-rk3066.c > @@ -82,7 +82,7 @@ static struct rockchip_pin_bank rk3066_pin_banks[] = { > PIN_BANK(6, 16, "gpio6"), > }; > > -static struct rockchip_pin_ctrl rk3066_pin_ctrl = { > +static const struct rockchip_pin_ctrl rk3066_pin_ctrl = { > .pin_banks = rk3066_pin_banks, > .nr_banks = ARRAY_SIZE(rk3066_pin_banks), > .grf_mux_offset = 0xa8, >