[U-Boot-Users] [PATCH] SPI relocation fix

Wolfgang Denk
2006-03-30T23:05:07Z

In message <11437528271561-git-send-email-davidho@nanometrics.ca> you wrote:
> Signed-off-by: David Ho <davidho@nanometrics.ca>

No CHANGELOG entry. No description what you're doing and why.

> + if (!mpc8xx_new_core()) {
> + /* Disable relocation */
> + spi->spi_rpbase = 0;
> + }

Also, I don't like the name "mpc8xx_new_core". What's "new"? It is
not exactly new by today, and will definitely not be new any more in
a year from now.

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Obviously, a major malfunction has occurred."
-- Steve Nesbitt, voice of Mission Control, January 28,
1986, as the shuttle Challenger exploded within view
of the grandstands.