* [U-Boot] [PATCH] s3c64xx: fix the compiler error and warning
@ 2012-10-26 8:15 Jaehoon Chung
2012-10-26 10:12 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2012-10-26 8:15 UTC (permalink / raw)
To: u-boot
From: Minkyu Kang <mk7.kang@samsung.com>
This patch is fixing the following errors
s3c64xx.c:175: error: variable 's3c64xx_serial_drv' has initializer but incomplete type
s3c64xx.c:176: error: unknown field 'name' specified in initializer
s3c64xx.c:176: warning: excess elements in struct initializer
s3c64xx.c:176: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:177: error: unknown field 'start' specified in initializer
s3c64xx.c:177: warning: excess elements in struct initializer
s3c64xx.c:177: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:178: error: unknown field 'stop' specified in initializer
s3c64xx.c:178: warning: excess elements in struct initializer
s3c64xx.c:178: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:179: error: unknown field 'setbrg' specified in initializer
s3c64xx.c:179: warning: excess elements in struct initializer
s3c64xx.c:179: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:180: error: unknown field 'putc' specified in initializer
s3c64xx.c:180: warning: excess elements in struct initializer
s3c64xx.c:180: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:181: error: unknown field 'puts' specified in initializer
s3c64xx.c:181: warning: excess elements in struct initializer
s3c64xx.c:181: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:182: error: unknown field 'getc' specified in initializer
s3c64xx.c:182: warning: excess elements in struct initializer
s3c64xx.c:182: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c:183: error: unknown field 'tstc' specified in initializer
s3c64xx.c:183: warning: excess elements in struct initializer
s3c64xx.c:183: warning: (near initialization for 's3c64xx_serial_drv')
s3c64xx.c: In function 's3c64xx_serial_initialize':
s3c64xx.c:188: warning: implicit declaration of function 'serial_register'
s3c64xx.c: At top level:
s3c64xx.c:191: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'struct'
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Cc: Marek Vasut <marex@denx.de>
---
drivers/serial/s3c64xx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/serial/s3c64xx.c b/drivers/serial/s3c64xx.c
index 9ab8a28..9886ec6 100644
--- a/drivers/serial/s3c64xx.c
+++ b/drivers/serial/s3c64xx.c
@@ -22,7 +22,8 @@
*/
#include <common.h>
-
+#include <linux/compiler.h>
+#include <serial.h>
#include <asm/arch/s3c6400.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -40,8 +41,6 @@ DECLARE_GLOBAL_DATA_PTR;
#error "Bad: you didn't configure serial ..."
#endif
-#define barrier() asm volatile("" ::: "memory")
-
/*
* The coefficient, used to calculate the baudrate on S3C6400 UARTs is
* calculated as
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] s3c64xx: fix the compiler error and warning
2012-10-26 8:15 [U-Boot] [PATCH] s3c64xx: fix the compiler error and warning Jaehoon Chung
@ 2012-10-26 10:12 ` Marek Vasut
2012-10-29 2:43 ` Minkyu Kang
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2012-10-26 10:12 UTC (permalink / raw)
To: u-boot
Dear Jaehoon Chung,
> From: Minkyu Kang <mk7.kang@samsung.com>
>
> This patch is fixing the following errors
[...]
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] s3c64xx: fix the compiler error and warning
2012-10-26 10:12 ` Marek Vasut
@ 2012-10-29 2:43 ` Minkyu Kang
0 siblings, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2012-10-29 2:43 UTC (permalink / raw)
To: u-boot
2012. 10. 26. 19:12 Marek Vasut <marex@denx.de> ??:
> Dear Jaehoon Chung,
>
>> From: Minkyu Kang <mk7.kang@samsung.com>
>>
>> This patch is fixing the following errors
> [...]
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Marek Vasut
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
applied to u-boot-samsung
Minkyu Kang.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-29 2:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 8:15 [U-Boot] [PATCH] s3c64xx: fix the compiler error and warning Jaehoon Chung
2012-10-26 10:12 ` Marek Vasut
2012-10-29 2:43 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox