[U-Boot-Users] [PATCH] fix incorrect comment in flash.h

[U-Boot-Users] [PATCH] fix incorrect comment in flash.h

[Andreas Engel]

CHANGELOG:

* fix incorrect comment for SST320/SST640 chips
  Patch by Andreas Engel, 22 May 2006
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sst.diff
Type: text/x-patch
Size: 941 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060522/c4a00d18/attachment.bin 

[U-Boot-Users] [PATCH] fix incorrect comment in flash.h

[Tolunay Orkun]

Andreas Engel wrote:
> CHANGELOG:
> 
> * fix incorrect comment for SST320/SST640 chips
>   Patch by Andreas Engel, 22 May 2006
> 
> 
> ------------------------------------------------------------------------
> 
> fixed wrong comment with SST320/SST640 chips
> 
> Signed-off-by: Andreas Engel <andreas.engel@marconi.com>
> 
> diff --git a/include/flash.h b/include/flash.h
> index a84dc68..94c7ff8 100644
> --- a/include/flash.h
> +++ b/include/flash.h
> @@ -341,8 +341,8 @@ #define FLASH_SST200A	0x0040		/* SST 39x
>  #define FLASH_SST400A	0x0042		/* SST 39xF400A ID (  4M = 256K x 16 )	*/
>  #define FLASH_SST800A	0x0044		/* SST 39xF800A ID (  8M = 512K x 16 )	*/
>  #define FLASH_SST160A	0x0046		/* SST 39xF160A ID ( 16M =   1M x 16 )	*/
> -#define FLASH_SST320	0x0048		/* SST 39xF160A ID ( 16M =   1M x 16 )	*/
> -#define FLASH_SST640	0x004A		/* SST 39xF160A ID ( 16M =   1M x 16 )	*/
> +#define FLASH_SST320	0x0048		/* SST 39xF160A ID ( 32M =   2M x 16 )	*/
> +#define FLASH_SST640	0x004A		/* SST 39xF160A ID ( 64M =   4M x 16 )	*/
>  #define FLASH_SST040	0x000E		/* SST 39xF040 ID (512KB = 4Mbit x 8 )	*/
>  
>  #define FLASH_STM800AB	0x0051		/* STM M29WF800AB  (  8M = 512K x 16 )	*/

Does SST640 and SST320 have the same ID as SST160A. The comment says: 
SST39xF160A ID for all 3 of these even in your corrected patch...

Best regards,
Tolunay

[U-Boot-Users] Re: [PATCH] fix incorrect comment in flash.h

[Andreas Engel]

Tolunay Orkun wrote:

> Does SST640 and SST320 have the same ID as SST160A. The comment says:
> SST39xF160A ID for all 3 of these even in your corrected patch...

You're right, of course. They don't have the same id. Here's an updated
patch.

CHANGELOG:

* fix incorrect comment for SST320/SST640 chips
  Patch by Andreas Engel, 23 May 2006

Thanks,
  Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sst.diff
Type: text/x-patch
Size: 942 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20060523/0a94275c/attachment.bin