From: Angelos Manousarides <amanous@inaccessnetworks.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Dynamic location of the environment sector
Date: Wed, 21 Jun 2006 20:21:45 +0300 [thread overview]
Message-ID: <44998029.9020708@inaccessnetworks.com> (raw)
In-Reply-To: <44997F0A.8010303@inaccessnetworks.com>
Angelos Manousarides wrote:
> Another problem I encountered has to do with the manipulation of the
> environment with the "saveenv" command. The image I produced was ok, I
> booted and the default environment was recognized. I saw that the file
> common/environment.c defines before the environment the env_size
> variable, therefore placing the environment at 0x4004 than 0x4000 that
> is my hard coded offset. This causes a problem with the saveenv command,
> since here (common/env_flash.c):
>
> #ifdef CMD_SAVEENV
> /* static env_t *flash_addr = (env_t *)(&environment[0]);-broken on
> ARM-wd-*/
> static env_t *flash_addr = (env_t *)(CFG_ENV_ADDR + sizeof(unsigned long));
> #endif
>
> the address the command uses is the initial offset (0x4000) and not the
> actual offset after the env_size variable.
>
> Is this a bug introduced by the workaround for the flash_addr? Or am I
> doing something wrong and the env_size variable should never have
> appeared in my code?
>
Ooops, sorry I forgot to mention that with the above line changed to:
static env_t *flash_addr = (env_t *)(CFG_ENV_ADDR + sizeof(unsigned long));
the saveenv command produced the desired result. I am not so sure if
this is the appropriate solution, it is a bit hard-coded, but I thought
I should mention it. It would be more desirable to infer the address of
the environment directly, but I am not sure how this can be done for the
PXA architecture (or in a unified way for all architectures for that
matter).
Regards,
Angelos Manousaridis
next prev parent reply other threads:[~2006-06-21 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 11:55 [U-Boot-Users] Dynamic location of the environment sector Angelos Manousarides
2006-06-14 14:31 ` Wolfgang Denk
2006-06-21 10:48 ` Angelos Manousarides
2006-06-21 14:11 ` Wolfgang Denk
2006-06-21 17:16 ` Angelos Manousarides
2006-06-21 17:21 ` Angelos Manousarides [this message]
2006-06-21 20:47 ` Wolfgang Denk
2006-06-21 20:46 ` Wolfgang Denk
2006-06-22 10:21 ` Angelos Manousarides
2006-06-22 10:44 ` Wolfgang Denk
2006-06-22 11:02 ` Angelos Manousarides
2006-06-26 14:57 ` Angelos Manousarides
2006-06-26 21:10 ` Wolfgang Denk
2006-06-27 9:20 ` Angelos Manousarides
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44998029.9020708@inaccessnetworks.com \
--to=amanous@inaccessnetworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox