public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Angelos Manousarides <amanous@inaccessnetworks.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Dynamic location of the environment sector
Date: Thu, 22 Jun 2006 13:21:54 +0300	[thread overview]
Message-ID: <449A6F42.9090509@inaccessnetworks.com> (raw)
In-Reply-To: <20060621204617.293D43525C5@atlas.denx.de>

Wolfgang Denk wrote:
> In message <44997F0A.8010303@inaccessnetworks.com> you wrote:
> 
>>Is this a bug introduced by the workaround for the flash_addr? Or am I 
>>doing something wrong and the env_size variable should never have 
>>appeared in my code?
> 
> 
> You must be doing something wrong.
> 

Ok. I found what the problem was. I was looking at the TRAB board which 
is a PXA board with the environment embedded and did exactly the same 
thing. What i did NOT notice is that it is mentioned explicitely in the 
common/environment.c file, and that is why it works and mine did not:

#if (defined(CONFIG_CMI)        || \
      defined(CONFIG_FADS)       || \
      defined(CONFIG_HYMOD)      || \
      defined(CONFIG_ICU862)     || \
      defined(CONFIG_R360MPI)    || \
      defined(CONFIG_TQM8xxL)    || \
      defined(CONFIG_RRVISION)   || \
      defined(CONFIG_TRAB)       || \
      defined(CONFIG_MRG110_6)   || \
      defined(CONFIG_PPCHAMELEONEVB) )   && \
      defined(ENV_CRC) /* Environment embedded in U-Boot .ppcenv section */
/* XXX - This only works with GNU C */
#  define __PPCENV__ __attribute__ ((section(".ppcenv")))
#  define __PPCTEXT__ __attribute__ ((section(".text")))

#elif defined(USE_HOSTCC) /* Native for 'tools/envcrc' */
#  define __PPCENV__ /*XXX DO_NOT_DEL_THIS_COMMENT*/
#  define __PPCTEXT__ /*XXX DO_NOT_DEL_THIS_COMMENT*/

#else /* Environment is embedded in U-Boot's .text section */
/* XXX - This only works with GNU C */
#  define __PPCENV__ __attribute__ ((section(".text")))
#  define __PPCTEXT__ __attribute__ ((section(".text")))
#endif


My board is not on the first #if, so it felt back to the last #else, 
thus placing the env_size and environment in the wrong order.

Regards,
Angelos Manousaridis

  reply	other threads:[~2006-06-22 10:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-14 11:55 [U-Boot-Users] Dynamic location of the environment sector Angelos Manousarides
2006-06-14 14:31 ` Wolfgang Denk
2006-06-21 10:48   ` Angelos Manousarides
2006-06-21 14:11     ` Wolfgang Denk
2006-06-21 17:16       ` Angelos Manousarides
2006-06-21 17:21         ` Angelos Manousarides
2006-06-21 20:47           ` Wolfgang Denk
2006-06-21 20:46         ` Wolfgang Denk
2006-06-22 10:21           ` Angelos Manousarides [this message]
2006-06-22 10:44             ` Wolfgang Denk
2006-06-22 11:02               ` Angelos Manousarides
2006-06-26 14:57                 ` Angelos Manousarides
2006-06-26 21:10                   ` Wolfgang Denk
2006-06-27  9:20                     ` Angelos Manousarides

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449A6F42.9090509@inaccessnetworks.com \
    --to=amanous@inaccessnetworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox