From: Michal Simek <michal.simek@amd.com>
To: Mayuresh Chitale <mchitale@ventanamicro.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2] net: axi_emac: Use reg property for DMA registers
Date: Mon, 13 Nov 2023 10:10:45 +0100 [thread overview]
Message-ID: <44fc3e3d-a2b6-4e71-8c95-d50ca7c45bcc@amd.com> (raw)
In-Reply-To: <20231111173604.93103-2-mchitale@ventanamicro.com>
On 11/11/23 18:36, Mayuresh Chitale wrote:
> As per the xlnx,axi-ethernet-1.00.a DT documentation in linux, the AXI
> DMA registers can be obtained via the reg property or via a separate
> node for the axistream DMA controller. Currently only the latter is
> supported, so add support to fetch the DMA controller registers from the
> "reg" property.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
> ---
> Changes in v2:
> ====
> Add Reviewed-by Tag.
>
> drivers/net/xilinx_axi_emac.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
> index 54f2232768..ef151ee51b 100644
> --- a/drivers/net/xilinx_axi_emac.c
> +++ b/drivers/net/xilinx_axi_emac.c
> @@ -903,12 +903,11 @@ static int axi_emac_of_to_plat(struct udevice *dev)
>
> ret = dev_read_phandle_with_args(dev, "axistream-connected", NULL, 0, 0,
> &axistream_node);
> - if (ret) {
> - printf("%s: axistream is not found\n", __func__);
> - return -EINVAL;
> - }
> + if (!ret)
> + plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
> + else
> + plat->dmatx = (struct axidma_reg *)dev_read_addr_index(dev, 1);
>
> - plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
> if (!plat->dmatx) {
> printf("%s: axi_dma register space not found\n", __func__);
> return -EINVAL;
This is the part of pcie series but it has nothing to do with it. Can you please
send it separately?
M
next prev parent reply other threads:[~2023-11-13 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 17:36 [PATCH v2] drivers: pcie_xilinx: Fix "reg" not found error Mayuresh Chitale
2023-11-11 17:36 ` [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
2023-11-13 9:10 ` Michal Simek [this message]
2023-11-16 13:22 ` mchitale
2023-11-11 17:36 ` [PATCH v2] pci: xilinx: Enable MMIO region Mayuresh Chitale
2023-11-13 8:10 ` [PATCH v2] drivers: pcie_xilinx: Fix "reg" not found error Michal Simek
2023-11-16 13:29 ` mchitale
2023-11-13 9:12 ` Michal Simek
2023-11-16 13:30 ` mchitale
-- strict thread matches above, loose matches on Subject: below --
2023-11-16 16:40 [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
2023-11-21 14:29 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44fc3e3d-a2b6-4e71-8c95-d50ca7c45bcc@amd.com \
--to=michal.simek@amd.com \
--cc=joe.hershberger@ni.com \
--cc=mchitale@ventanamicro.com \
--cc=rfried.dev@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox