From: Roger Quadros <rogerq@kernel.org>
To: Ken Sloat <ken.s@variscite.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"mripard@kernel.org" <mripard@kernel.org>,
"dannenberg@ti.com" <dannenberg@ti.com>,
"sjg@chromium.org" <sjg@chromium.org>,
"s-anna@ti.com" <s-anna@ti.com>,
"s-vadapalli@ti.com" <s-vadapalli@ti.com>,
"rfried.dev@gmail.com" <rfried.dev@gmail.com>,
"joe.hershberger@ni.com" <joe.hershberger@ni.com>
Cc: Nate Drude <Nate.D@variscite.com>, Eran Matityahu <eran.m@variscite.com>
Subject: Re: [PATCH v2 1/1] net: ti: am65-cpsw-nuss: Remove incorrect RGMII_ID bit functionality
Date: Fri, 2 Feb 2024 14:29:08 +0200 [thread overview]
Message-ID: <44fdf099-1810-447b-9f25-ecc6c9629a6a@kernel.org> (raw)
In-Reply-To: <AS8PR08MB79915B184330438FBFE664DAEC432@AS8PR08MB7991.eurprd08.prod.outlook.com>
On 01/02/2024 22:17, Ken Sloat wrote:
> The CPSW implementations on the AM6x platforms do not support the
> selectable RGMII TX clk delay functionality via the RGMII_ID_MODE bit as
> the earlier platforms did. While it is possible to write the bit,
> according to various TI AM6x datasheets, reference manuals, hardware
> design guides and TI forum posts from TI, this bit is "not timed, tested
> or characterized. RGMII_ID is enabled by default."
>
> The driver implementation today however, will incorrectly set this bit
> whenever the interface mode is in RGMII_ID or RGMII_TXID. Since
> disabling the delay (bit=1) is not supported by TI, this bit should
> always be written as 0.
>
> See:
> https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1211306/am625-enet1_ctrl_rgmii_id-_mode
> https://www.ti.com/lit/pdf/spruiv7 (Rev. B Figure 14-1717)
> https://www.ti.com/lit/gpn/am625 (Rev. B Figure 7-31 Note A)
> https://www.ti.com/lit/an/sprad05b/sprad05b.pdf (Rev. B Section 7.4)
>
> Signed-off-by: Ken Sloat <ken.s@variscite.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
next prev parent reply other threads:[~2024-02-02 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 20:17 [PATCH v2 1/1] net: ti: am65-cpsw-nuss: Remove incorrect RGMII_ID bit functionality Ken Sloat
2024-02-02 12:29 ` Roger Quadros [this message]
2024-03-01 14:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44fdf099-1810-447b-9f25-ecc6c9629a6a@kernel.org \
--to=rogerq@kernel.org \
--cc=Nate.D@variscite.com \
--cc=dannenberg@ti.com \
--cc=eran.m@variscite.com \
--cc=joe.hershberger@ni.com \
--cc=ken.s@variscite.com \
--cc=mripard@kernel.org \
--cc=rfried.dev@gmail.com \
--cc=s-anna@ti.com \
--cc=s-vadapalli@ti.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox