From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schweigstill Date: Mon, 16 Oct 2006 13:48:03 +0200 Subject: [U-Boot-Users] Adding new commands In-Reply-To: <453368A1.5050407@dave-tech.it> References: <453368A1.5050407@dave-tech.it> Message-ID: <45337173.2070801@schweigstill.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear llandre! llandre schrieb: > #define CFG_CMD_NEW1 0x8000000000000000ULL > #define CFG_CMD_NEW2 ??? > > IIUC we have 64 bits available for the commands and 63 commands are > already defined. So how to define more than 64 commands? This is indeed a big problem which will occur to nearly every developer who implements new commands. CFG_CMD_* and CONFIG_COMMANDS are only used for preprocessor evaluation; they don't seem to be used in object code. But they rely on the ULL (unsigned long long int) type; I don't think that there is something like a 128bit type which can be used directly for logical AND operations. For new command there could be used another macro like CONFIG_COMMANDS2 and CFG_CMD2_* for the configuration values. Here are some statistics about usage of the old definitions: CONFIG_COMMANDS: about 1650 entries in 470 files CFG_CMD: about 4126 entries in 470 With best regards Andreas Schweigstill -- Dipl.-Phys. Andreas Schweigstill Schweigstill IT | Embedded Systems Schauenburgerstra?e 116, D-24118 Kiel, Germany Phone: (+49) 431 5606-435, Fax: (+49) 431 5606-436 Mobile: (+49) 171 6921973, Web: http://www.schweigstill.de/