From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Date: Mon, 23 Oct 2006 09:58:33 +0200 Subject: [U-Boot-Users] ixdp 465 In-Reply-To: <20061020073224.026E9353CB4@atlas.denx.de> References: <20061020073224.026E9353CB4@atlas.denx.de> Message-ID: <453C7629.4050701@evidence.eu.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Wolfgang Denk wrote: >Such a plain diff output is not a patch, it cannot be applied. Please >make sure to read the README, section Submitting Patches. You MUST >use the correct options when creating the patch. > Ok, some people ask me for a patch because they need it. I will produce a better patch. > >Also mind the size limitations on the mailing list. > >And make sure to stick to the required coding style, your code >contains lots of problems (indentation by spaces instead of TABs, C++ >comments, trailing white space, etc.). > thank's, I'm going to fix > >Also never add change log entires to any files. We use git for this >purpose. > Ok > >Make sure your code does not contain dead code (#if 0 etc.). > The dead code is already present, I just add my code, without dead code. Thank's a lot for your comment > > > >Please cleanup and resubmit. > >Best regards, > >Wolfgang Denk > > Regards Michael