From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Sector size with CFI driver?
Date: Wed, 01 Nov 2006 11:41:31 -0600 [thread overview]
Message-ID: <4548DC4B.6010500@orkun.us> (raw)
In-Reply-To: <4548D496.3090605@freescale.com>
Timur Tabi wrote:
> Stefan Roese wrote:
>> On Wednesday 01 November 2006 17:58, Timur Tabi wrote:
>>> Timur Tabi wrote:
>>>> +
>>>> +#ifdef CONFIG_MPC8349ITX
>>>> + for (i = num_erase_regions-1; i >= 0; i--) { /* top
>>>> boot */ +#else
>>>> for (i = 0; i < num_erase_regions; i++) {
>>>> +#endif
>>>> +
>>> Ok, I put the above change into cfi_flash.c, and now it works! Can someone
>>> explain to me why? Does U-Boot not normally support "top boot" flash? If
>>> so, is there a better way of doing this?
>> Seems like your FLASH doesn't really support the CFI "Device Geometry
>> Definition". Both versions (top & bottom boot block) most likely report the
>> same layout.
>
> Assuming this is true (and I will try to find out), can you recommend how you
> want me to implement a fix for my board? Should I do something like
>
> #define CFG_CFI_DEV_GEO_BROKEN
>
> in my board header file, and then do something like:
>
> +#ifdef CFG_CFI_DEV_GEO_BROKEN
> + for (i = num_erase_regions-1; i >= 0; i--) {
> +#else
> for (i = 0; i < num_erase_regions; i++) {
> +#endif
>
> This is really ugly, I know, but I need help coming up with a method that you
> guys will accept.
I would not assume that all broken geometry to be one way or another.
Secondly, it looks like the erase region list returned is reversed for
this flash chip. I think, CFG_CFI_GEOMETRY_REVERSED would be more
appropriate.
Perhaps you can identify such a reserved list from the CFI tables on the
flash. If this can be done no macros would be needed to handle this case.
Can you tell me the exact part number for your flash. I would like to
read the data sheet and compare its CFI structures if I can.
Best regards,
Tolunay
next prev parent reply other threads:[~2006-11-01 17:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 20:00 [U-Boot-Users] Sector size with CFI driver? Timur Tabi
2006-10-31 20:53 ` Tolunay Orkun
2006-10-31 21:40 ` Timur Tabi
2006-10-31 21:59 ` Tolunay Orkun
2006-10-31 23:08 ` Timur Tabi
2006-11-01 13:05 ` Stefan Roese
2006-11-01 16:34 ` Timur Tabi
2006-11-01 16:44 ` Ben Warren
2006-11-01 16:58 ` Timur Tabi
2006-11-01 17:02 ` Stefan Roese
2006-11-01 17:08 ` Timur Tabi
2006-11-01 17:41 ` Tolunay Orkun [this message]
2006-11-01 17:52 ` Timur Tabi
2006-11-01 17:47 ` Tolunay Orkun
-- strict thread matches above, loose matches on Subject: below --
2006-11-01 17:47 Yogi
2006-11-01 18:29 Yogi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4548DC4B.6010500@orkun.us \
--to=listmember@orkun.us \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox