From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot?
Date: Mon, 06 Nov 2006 18:51:04 -0600 [thread overview]
Message-ID: <454FD878.7070909@orkun.us> (raw)
In-Reply-To: <11628568123033-git-send-email-timur@freescale.com>
timur at freescale.com wrote:
> From: Timur Tabi <timur@freescale.com>
>
> This patch adds support for the reversed geometry data in some AMD flash
> chips.
>
> I'm not proud of this patch, so I'm posting it for review only. I know it
> works on the my board that was the problem, but I have no idea if it will
> break any other board. I'm sure this code could be improved a lot.
NAK. It will break any bottom boot AMD flash. I have reviewed Linux MTD
driver and the coder had nice things to say about AMD regarding this
matter (!).
Anyway, I will get proper patch to you to try tonight or tomorrow. I do
not have a board with AMD flash myself.
Tolunay
next prev parent reply other threads:[~2006-11-07 0:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 23:46 [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot? timur at freescale.com
2006-11-07 0:51 ` Tolunay Orkun [this message]
2006-11-07 1:09 ` [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check fortop/bottom boot? Spence Nick-rxtd10
2006-11-07 10:57 ` [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot? Tolunay Orkun
2006-11-07 17:24 ` Timur Tabi
2006-11-07 18:01 ` Tolunay Orkun
2006-11-07 18:16 ` Stefan Roese
2006-11-07 23:05 ` Tolunay Orkun
2006-11-07 23:19 ` Tolunay Orkun
2006-11-07 17:50 ` Spence Nick-rxtd10
2006-11-07 18:14 ` Tolunay Orkun
2006-11-07 18:38 ` Timur Tabi
2006-11-07 18:46 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454FD878.7070909@orkun.us \
--to=listmember@orkun.us \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox