From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tolunay Orkun Date: Mon, 06 Nov 2006 18:51:04 -0600 Subject: [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot? In-Reply-To: <11628568123033-git-send-email-timur@freescale.com> References: <11628568123033-git-send-email-timur@freescale.com> Message-ID: <454FD878.7070909@orkun.us> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de timur at freescale.com wrote: > From: Timur Tabi > > This patch adds support for the reversed geometry data in some AMD flash > chips. > > I'm not proud of this patch, so I'm posting it for review only. I know it > works on the my board that was the problem, but I have no idea if it will > break any other board. I'm sure this code could be improved a lot. NAK. It will break any bottom boot AMD flash. I have reviewed Linux MTD driver and the coder had nice things to say about AMD regarding this matter (!). Anyway, I will get proper patch to you to try tonight or tomorrow. I do not have a board with AMD flash myself. Tolunay