From: Sylvain Munaut <tnt@246tNt.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] [MPC52xx] Use IPB bus frequency for SOC peripherals
Date: Thu, 16 Nov 2006 09:45:58 +0100 [thread overview]
Message-ID: <455C2546.4050600@246tNt.com> (raw)
In-Reply-To: <20061106212007.8A923353C4E@atlas.denx.de>
Wolfgang Denk wrote:
> In message <1162846858442-git-send-email-grant.likely@secretlab.ca> you wrote:
>
>> The soc node of the mpc52xx needs to be loaded with the IPB bus frequency,
>> not the XLB frequency.
>>
> ...
>
>
>> p = ft_get_prop(blob, "/cpus/" OF_CPU "/bus-frequency", &len);
>> if (p != NULL)
>> - *p = cpu_to_be32(clock);
>> + *p = cpu_to_be32(bd->bi_busfreq);
>>
>
> "/bus-frequency" ==> bi_busfreq. OK.
>
>
>> p = ft_get_prop(blob, "/" OF_SOC "/bus-frequency", &len);
>> if (p != NULL)
>> - *p = cpu_to_be32(clock);
>> + *p = cpu_to_be32(bd->bi_ipbfreq);
>>
>
> "/bus-frequency" ==> bi_ipbfreq. ???
>
FWIW,
Looks good to me and it's a requirement for the new arch/powerpc that's
coming soon.
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Sylvain
next prev parent reply other threads:[~2006-11-16 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 21:00 [U-Boot-Users] [PATCH] [MPC52xx] Use IPB bus frequency for SOC peripherals Grant Likely
2006-11-06 21:20 ` Wolfgang Denk
2006-11-06 21:36 ` Grant Likely
2006-11-06 22:35 ` Wolfgang Denk
2006-11-06 22:36 ` Grant Likely
2006-11-07 13:27 ` [U-Boot-Users] [PATCH] [MPC52xx] Use IPB bus frequency for SOC peripherals / OF patches Jerry Van Baren
2006-11-16 8:45 ` Sylvain Munaut [this message]
2006-11-30 12:05 ` [U-Boot-Users] [PATCH] [MPC52xx] Use IPB bus frequency for SOC peripherals Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455C2546.4050600@246tNt.com \
--to=tnt@246tnt.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox