From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Thu, 07 Dec 2006 11:25:16 -0600
Subject: [U-Boot-Users] possible ELDK4 gcc compiler bug
In-Reply-To: <200612071812.39035.matthias.fuchs@esd-electronics.com>
References: <200612071721.10783.matthias.fuchs@esd-electronics.com>	<200612071728.30527.matthias.fuchs@esd-electronics.com>	<29294F14-A88D-4027-A941-B5AF3DE19B87@gmail.com>
	<200612071812.39035.matthias.fuchs@esd-electronics.com>
Message-ID: <45784E7C.5040704@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Matthias Fuchs wrote:

> 
> Do so with accessors result in code like this (still missing some casts):
> 
> out32(&(fpga->fifo[i].ctrl), in32(&(fpga->fifo[i].ctrl)) | 0x8000);
> 
> Is this really recommended?

That's how I would do it.  You could use a temporary variable:

u32 ctrl;

ctrl = in32(&(fpga->fifo[i].ctrl));
out32(&(fpga->fifo[i].ctrl), ctrl | 0x8000);

-- 
Timur Tabi
Linux Kernel Developer @ Freescale