From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Updegraff Date: Fri, 05 Jan 2007 09:24:51 -0600 Subject: [U-Boot-Users] do_bootm_linux OF_FLAT_TREE In-Reply-To: <7400B4CB-94E7-410D-B242-7910BE61BEBD@kernel.crashing.org> References: <7400B4CB-94E7-410D-B242-7910BE61BEBD@kernel.crashing.org> Message-ID: <459E6DC3.9040900@cray.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: > > On Jan 3, 2007, at 1:18 PM, David Updegraff wrote: > >> Hi. >> >> in common/cmd_boot, around line 624: >> >> Looks like there is a small hole in the logic here if you happen to want >> to boot with a MULTI image with a ptr. and flat_tree. Since >> "boot multi_img_addr - of_tree_addr" >> ends up falling into the 'Skipping initrd category'. Which is annoying, >> as it looses the initrd that is inside the MULTI img. >> >> An obvious solution does not pop out at me. >> >> Maybe special-case check for MULTI within that special-case of FLAT_TREE >> and argv=='-' ? >> >> Please suggest better way. Thnx. > > When I implemented this I felt that it was an all or nothing situation. > Either you specified the memory locations of the kernel, initrd, and dtb > or you used a single MULTI image. > > One problem was that the MULTI image doesn't include any header > information to know what the "sections" of the image are. > > - k Right... but the _assumption_ everywhere in *_bootm seems to be that MULTI = kernel + initrd so my view would be to not introduce another [unfounded?] assumption that .. eg. MULTI = kernel + initrd + dtb. So; yes; it'd be maybe nice to have the picking apart of MULTI off in its own func so its done consistently.. or, at a cost of more duct-tape, but less overall impact-full might be enclosed patch. I dunno; still hoping & searching for a less-duct-tape solution. -dbu -------------- next part -------------- A non-text attachment was scrubbed... Name: multi-dtd.patch Type: text/x-patch Size: 1101 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20070105/9bc5b1d6/attachment.bin