public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR
@ 2007-01-10 16:58 Timur Tabi
  2007-01-10 23:19 ` Wolfgang Denk
  0 siblings, 1 reply; 4+ messages in thread
From: Timur Tabi @ 2007-01-10 16:58 UTC (permalink / raw)
  To: u-boot

What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR?  Looking at the 
code, it looks like their both used as default load addresses, but I don't see 
why they should have different values (they do in most header files).

The README also talks about CFG_TFTP_LOADADDR, but I don't see where that's used 
in the code.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR
  2007-01-10 16:58 [U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR Timur Tabi
@ 2007-01-10 23:19 ` Wolfgang Denk
  2007-01-10 23:31   ` Timur Tabi
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2007-01-10 23:19 UTC (permalink / raw)
  To: u-boot

In message <45A51B26.4030803@freescale.com> you wrote:
> What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR?  Looking at the 

One underscore, a 'O', a 'N', and a 'I' ;-)


CFG_LOAD_ADDR is what you are supposed to use in the code.

CONFIG_LOADADDR is the value used to initialize the "loadaddr"
variable in the default environment.

> code, it looks like their both used as default load addresses, but I don't see 
> why they should have different values (they do in most header files).

I see little reason to define CONFIG_LOADADDR at all.

> The README also talks about CFG_TFTP_LOADADDR, but I don't see where that's used 
> in the code.

It ain't used, and should be removed.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust.  We trust you will pay in advance.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR
  2007-01-10 23:19 ` Wolfgang Denk
@ 2007-01-10 23:31   ` Timur Tabi
  2007-01-10 23:53     ` Wolfgang Denk
  0 siblings, 1 reply; 4+ messages in thread
From: Timur Tabi @ 2007-01-10 23:31 UTC (permalink / raw)
  To: u-boot

Wolfgang Denk wrote:

>> What's the difference between CFG_LOAD_ADDR and CONFIG_LOADADDR?  Looking at the 
> 
> One underscore, a 'O', a 'N', and a 'I' ;-)

Otto Waalkes could take lessons from you.

> CFG_LOAD_ADDR is what you are supposed to use in the code.
> 
> CONFIG_LOADADDR is the value used to initialize the "loadaddr"
> variable in the default environment.
> 
>> code, it looks like their both used as default load addresses, but I don't see 
>> why they should have different values (they do in most header files).
> 
> I see little reason to define CONFIG_LOADADDR at all.

Then what's the best way to define a default value for the "loadaddr" variable?

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR
  2007-01-10 23:31   ` Timur Tabi
@ 2007-01-10 23:53     ` Wolfgang Denk
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2007-01-10 23:53 UTC (permalink / raw)
  To: u-boot

In message <45A5776C.9060409@freescale.com> you wrote:
> 
> > CONFIG_LOADADDR is the value used to initialize the "loadaddr"
> > variable in the default environment.
...
> > I see little reason to define CONFIG_LOADADDR at all.
> 
> Then what's the best way to define a default value for the "loadaddr" variable?

Define CONFIG_LOADADDR.

But, as mentioned implicitely before, I see little reason  to  define
the "loadaddr" variable at all.

Define CFG_LOAD_ADDR, and that's it. Having more than one defualt
value seems a broken design to me.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A dirty mind is a joy forever."                       - Randy Kunkee

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-01-10 23:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-10 16:58 [U-Boot-Users] CFG_LOAD_ADDR vs. CONFIG_LOADADDR vs. CFG_TFTP_LOADADDR Timur Tabi
2007-01-10 23:19 ` Wolfgang Denk
2007-01-10 23:31   ` Timur Tabi
2007-01-10 23:53     ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox