From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Fri, 26 Jan 2007 15:49:47 -0600 Subject: [U-Boot-Users] [PATCH] Add support for the MPC8349E-mITX-GP In-Reply-To: <20070126214631.BF238353CC1@atlas.denx.de> References: <20070126214631.BF238353CC1@atlas.denx.de> Message-ID: <45BA777B.303@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <45BA718E.1070005@freescale.com> you wrote: >> The patch currently does this: >> >> MPC8349ITX_config \ >> MPC8349ITX_LOWBOOT_config \ >> MPC8349ITXGP_config: unconfig >> @mkdir -p $(obj)include >> @mkdir -p $(obj)board/mpc8349itx >> @CTYPE=$(subst MPC,,$(@:_config=)); \ >> echo "#define CONFIG_MPC$${CTYPE}" >> $(obj)include/config.h >> @if [ "$(findstring GP,$@)" ] ; then \ >> echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ; \ >> fi >> @if [ "$(findstring LOWBOOT,$@)" ] ; then \ >> echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ; \ >> fi >> @$(MKCONFIG) -a MPC8349ITX ppc mpc83xx mpc8349itx > > I would not reject such a patch. It looks resonable to me. [You could > get rid of the CTYPE thingy which would save one line.] How else would I do this, then? echo "#define CONFIG_MPC$${CTYPE}" >> $(obj)include/config.h ^^^^^^^^^ -- Timur Tabi Linux Kernel Developer @ Freescale