[U-Boot-Users] Atmel DataFlash hooks.

Grant Likely
2007-01-26T20:27:08Z

On 1/26/07, Ulf Samuelsson <ulfs@dof.se> wrote:
> Grant Likely wrote:
> > On 1/26/07, Ulf Samuelsson <ulfs@dof.se> wrote:
> >
> >> Are you prepared to make the fixes so that all Atmel development kits
> >> are supported by your patches.
> >> This means taking the atmnel patches from the Atmel ftp site and
> >> test them thoroughly on the appropriate boards.
> >
> > No. If the board port is not in mainline, then it is the
> > responsibility of the port maintainer to keep it synced.
> >
>
> Now with the new approach to introducing patches,
> I think the SAM9 patches should be sent in soon
> and you will have a significant number of boards
> that will break if you screw up.

Just because I write the patches doesn't mean they get accepted. They
need to be acked by someone who has tested them first. I'm offering
to take on the workload of writing the patches, but I cannot take on
the testing. A number of the changes that I'm making right now (not
just DataFlash) affect every single board, but I cannot test them all.
Best I can do is make sure it works on the handful of boards I do
have, post the patches for others to test, and only request inclusion
in mainline when nobody reports problems with them.

>
> > For the stuff that *is* in mainline, I will of course make sure that
> > the patches compile, but I cannot test them. I do not have the
> > hardware to do so, nor will I spend the time to test boards that I
> > have absolutely no involvement with.
> >
>
> That sound like a great idea, introduce significant modifications
> without testing...

The mods I'm interested in are the architectural changes which I can
and will test. The DataFlash changes are collateral damage. The
alternative for me is to break dataflash support without even
attempting to providing a solution.

>
> I think you should spend time on modifying things you *can* test.

Then how does *anybody* attempt to fix common code? Nobody can test
all platforms.

Cheers,
g.

--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195