From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Fix empty i2c reads/writes in fsl_i2c.c
Date: Wed, 31 Jan 2007 10:27:18 -0600 [thread overview]
Message-ID: <45C0C366.3000800@freescale.com> (raw)
In-Reply-To: <045801c74554$86ac59c0$1e67a8c0@Jocke>
Joakim Tjernlund wrote:
>> will never call "__i2c_read(data, length)", and so it will
>> never set the value
>> of i. Then it will return, indicating success.
>
> No, i will be 0 and length will be !=0 so no success.
Oh yeah, right.
> Yes, I agree. The orginal freescale code looked something like that,
> but I am not going to rewrite it back to that form. Someone did
> change it to this form.
Really? That's weird. Oh well. In that case, your patch is okay.
--
Timur Tabi
Linux Kernel Developer @ Freescale
prev parent reply other threads:[~2007-01-31 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 10:04 [U-Boot-Users] Fix empty i2c reads/writes in fsl_i2c.c Joakim Tjernlund
2007-01-31 15:58 ` Timur Tabi
2007-01-31 16:26 ` Joakim Tjernlund
2007-01-31 16:27 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C0C366.3000800@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox