From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timur Tabi <timur@freescale.com>
Date: Wed, 31 Jan 2007 10:27:18 -0600
Subject: [U-Boot-Users] Fix empty i2c reads/writes in fsl_i2c.c
In-Reply-To: <045801c74554$86ac59c0$1e67a8c0@Jocke>
References: <045801c74554$86ac59c0$1e67a8c0@Jocke>
Message-ID: <45C0C366.3000800@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Joakim Tjernlund wrote:

>> will never call "__i2c_read(data, length)", and so it will 
>> never set the value 
>> of i.  Then it will return, indicating success.
> 
> No, i will be 0 and length will be !=0 so no success.

Oh yeah, right.

> Yes, I agree. The orginal freescale code looked something like that,
> but I am not going to rewrite it back to that form. Someone did
> change it to this form.

Really?  That's weird.  Oh well.  In that case, your patch is okay.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale