From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [DNX#2007012542000021] [PATCH] Abort booting if the DTB version is incomp [...]
Date: Mon, 05 Feb 2007 13:38:00 -0600 [thread overview]
Message-ID: <45C78798.1030807@freescale.com> (raw)
In-Reply-To: <1169742004.156503.051336014@castor.denx.de>
Wolfgang,
Can you tell if and when this patch will be applied?
I also submitted another patch titled "Add support for generating assembly
listing files".
OTRS Notification Master wrote:
> Hello list,
>
> inside the automatic U-Boot patch tracking system a new ticket
> [DNX#2007012542000021] was created:
>
> <snip>
>> U-Boot only supports version 16 of the device tree file format, although
>> some
>> versions of the device tree compiler generate version 3 by default.
>> With
>> this patch, U-Boot now checks the version number and aborts the boot
>> process
>> if the version of the device tree passed on the bootm command line is
>> not
>> compatible.
>>
>> Signed-off-by: Timur Tabi <timur@freescale.com>
>> ---
>> common/cmd_bootm.c | 10 ++++++++++
>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
>> index 0c092c7..9111cbd 100644
>> --- a/common/cmd_bootm.c
>> +++ b/common/cmd_bootm.c
>> @@ -741,6 +741,16 @@ do_bootm_linux (cmd_tbl_t *cmdtp, int fl
>> hdr = (image_header_t *)of_flat_tree;
>>
>> if (*(ulong *)of_flat_tree == OF_DT_HEADER) {
>> + struct boot_param_header *bph =
>> + (struct boot_param_header *) of_flat_tree;
>> +
>> + if ((OF_DT_VERSION < be32_to_cpu(bph->last_comp_version)) ||
>> + (OF_DT_VERSION > be32_to_cpu(bph->version))) {
>> + printf("ERROR: DTB version %u is not compatible with version %u " \
>> + "(last_comp_version=%u)\n", be32_to_cpu(bph->version),
>> + OF_DT_VERSION, be32_to_cpu(bph->last_comp_version));
>> + return;
>> + }
>> #ifndef CFG_NO_FLASH
>> if (addr2info((ulong)of_flat_tree) != NULL)
>> of_data = (ulong)of_flat_tree;
>> --
>> 1.4.4
> </snip>
>
> Your U-Boot support team
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-02-05 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 16:20 [U-Boot-Users] [DNX#2007012542000021] [PATCH] Abort booting if the DTB version is incomp [...] OTRS Notification Master
2007-02-05 19:38 ` Timur Tabi [this message]
2007-02-06 0:40 ` Wolfgang Denk
2007-03-14 19:58 ` Timur Tabi
2007-03-14 20:36 ` Wolfgang Denk
2007-03-14 21:01 ` Stefan Roese
2007-03-14 21:04 ` Wolfgang Denk
2007-03-14 21:22 ` Ben Warren
2007-03-14 23:12 ` Wolfgang Denk
2007-03-14 21:07 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C78798.1030807@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox