From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tolunay Orkun <listmember@orkun.us>
Date: Tue, 06 Feb 2007 02:50:08 -0600
Subject: [U-Boot-Users] [PATCH] Add sync at the end of flash_write_cmd
 for MPC86xx
In-Reply-To: <200702060806.50420.sr@denx.de>
References: <1170706772.3901.14.camel@udp097531uds.am.freescale.net>
	<c166aa9f0702051301k65b90a35pf066ea1baefc646f@mail.gmail.com>
	<1defaf580702051311w22b6892aq78e8ff6abc02ff64@mail.gmail.com>
	<200702060806.50420.sr@denx.de>
Message-ID: <45C84140.3010909@orkun.us>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Stefan Roese wrote:
> On Monday 05 February 2007 22:11, Haavard Skinnemoen wrote:
>>> #ifdef SYNC
>>>     SYNC;
>>> #endif
>> Better to drop the #ifdef and just add empty stubs for the arches that
>> don't need it.
> 
> Yes, please do it this way.

I think defining the SYNC macro in architecture files is probably better 
but #ifdef wrapper would avoid touching architectures that does not have 
SYNC concept.

I guess at this moment we need a real (not a stub) SYNC for all PowerPC 
variants and Blackfin. I do not know if other architectures supported by 
U-Boot have such instructions in instruction set. So, it is probably the 
best time for those architecture people to speak up.

I think this patch should be independent than the cfi_flash.c patch. 
cfi_flash.c patch will depend on this patch applied first.

Best regards,
Tolunay