From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add FLASH_CMD_SYNC macro for flash_write_cmd
Date: Thu, 08 Feb 2007 02:40:54 -0600 [thread overview]
Message-ID: <45CAE216.7080208@orkun.us> (raw)
In-Reply-To: <11708246522001-git-send-email-haiying.wang@freescale.com>
haiying.wang at freescale.com wrote:
> +#ifdef FLASH_CMD_SYNC
> + sync();
> +#endif
> }
>
I think you misunderstood the last change request regarding your patch.
Please re-read my earlier email. As discussed on the mailing list we do
not need/want a FLASH_CMD_SYNC.
1) In your cfi_flash.c::flash_write_cmd() patch instead of
#ifdef FLASH_CMD_SYNC
sync();
#endif
Use
SYNC;
2) In a separate patch define SYNC for all CPU architectures (i.e. add
the definition of SYNC to all CPU header files. For example, each
PowerPC based CPU support file will have the following line added.
#define SYNC asm("sync;")
You will have to add this to PowerPC and BLACKFIN at this moment. Others
will need to have a dummy define so builds must not break.
#define SYNC /* stub */
Please re-do the patches and resubmit.
parent reply other threads:[~2007-02-08 8:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <11708246522001-git-send-email-haiying.wang@freescale.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CAE216.7080208@orkun.us \
--to=listmember@orkun.us \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox