* [U-Boot-Users] [PATCH] Add FLASH_CMD_SYNC macro for flash_write_cmd
[not found] <11708246522001-git-send-email-haiying.wang@freescale.com>
@ 2007-02-08 8:40 ` Tolunay Orkun
0 siblings, 0 replies; only message in thread
From: Tolunay Orkun @ 2007-02-08 8:40 UTC (permalink / raw)
To: u-boot
haiying.wang at freescale.com wrote:
> +#ifdef FLASH_CMD_SYNC
> + sync();
> +#endif
> }
>
I think you misunderstood the last change request regarding your patch.
Please re-read my earlier email. As discussed on the mailing list we do
not need/want a FLASH_CMD_SYNC.
1) In your cfi_flash.c::flash_write_cmd() patch instead of
#ifdef FLASH_CMD_SYNC
sync();
#endif
Use
SYNC;
2) In a separate patch define SYNC for all CPU architectures (i.e. add
the definition of SYNC to all CPU header files. For example, each
PowerPC based CPU support file will have the following line added.
#define SYNC asm("sync;")
You will have to add this to PowerPC and BLACKFIN at this moment. Others
will need to have a dummy define so builds must not break.
#define SYNC /* stub */
Please re-do the patches and resubmit.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-02-08 8:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <11708246522001-git-send-email-haiying.wang@freescale.com>
2007-02-08 8:40 ` [U-Boot-Users] [PATCH] Add FLASH_CMD_SYNC macro for flash_write_cmd Tolunay Orkun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox