[U-Boot-Users] [PATCH] Add FLASH_CMD_SYNC macro for flash_write_cmd

Tolunay Orkun
2007-02-08T08:40:54Z

haiying.wang at freescale.com wrote:

> +#ifdef FLASH_CMD_SYNC
> + sync();
> +#endif
> }
>

I think you misunderstood the last change request regarding your patch.
Please re-read my earlier email. As discussed on the mailing list we do
not need/want a FLASH_CMD_SYNC.

1) In your cfi_flash.c::flash_write_cmd() patch instead of

#ifdef FLASH_CMD_SYNC
sync();
#endif

Use

SYNC;

2) In a separate patch define SYNC for all CPU architectures (i.e. add
the definition of SYNC to all CPU header files. For example, each
PowerPC based CPU support file will have the following line added.

#define SYNC asm("sync;")

You will have to add this to PowerPC and BLACKFIN at this moment. Others
will need to have a dummy define so builds must not break.

#define SYNC /* stub */

Please re-do the patches and resubmit.