public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] Bugfix for S3C24x0 usb-ohci driver
@ 2007-02-17  7:46 "David Müller (ELSOFT AG)"
  2007-02-17 14:54 ` Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: "David Müller (ELSOFT AG)" @ 2007-02-17  7:46 UTC (permalink / raw)
  To: u-boot

Hello

According to the S3C2410 user's manual, the clock enabling/disabling for
the USB host controller is done by bit 6, not 4 (which is the NAND
controller). The attach patch fixes this error.

ChangeLog:
* Fix incorrect bit number in s3c24x0/usb_ohci.c

Dave
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: usb_ohci.c.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070217/7c5a5118/attachment.txt 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] Bugfix for S3C24x0 usb-ohci driver
  2007-02-17  7:46 [U-Boot-Users] [PATCH] Bugfix for S3C24x0 usb-ohci driver "David Müller (ELSOFT AG)"
@ 2007-02-17 14:54 ` Wolfgang Denk
  2007-02-19  7:57   ` "David Müller (ELSOFT AG)"
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2007-02-17 14:54 UTC (permalink / raw)
  To: u-boot

In message <45D6B2E1.7070508@elsoft.ch> you wrote:
> 
> According to the S3C2410 user's manual, the clock enabling/disabling for
> the USB host controller is done by bit 6, not 4 (which is the NAND
> controller). The attach patch fixes this error.

I don't have my S3C2400 manual here - will this also work on S3C2400
systems?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When you die, the first thing you lose is your life. The  next  thing
is the illusions.                       - Terry Pratchett, _Pyramids_

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] Bugfix for S3C24x0 usb-ohci driver
  2007-02-17 14:54 ` Wolfgang Denk
@ 2007-02-19  7:57   ` "David Müller (ELSOFT AG)"
  0 siblings, 0 replies; 3+ messages in thread
From: "David Müller (ELSOFT AG)" @ 2007-02-19  7:57 UTC (permalink / raw)
  To: u-boot

Wolfgang Denk wrote:
> I don't have my S3C2400 manual here - will this also work on S3C2400
> systems?

Ok, i missed this point. Here is a better patch.


Dave

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: usb_ochi.c.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070219/25f11ca3/attachment.txt 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-02-19  7:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-17  7:46 [U-Boot-Users] [PATCH] Bugfix for S3C24x0 usb-ohci driver "David Müller (ELSOFT AG)"
2007-02-17 14:54 ` Wolfgang Denk
2007-02-19  7:57   ` "David Müller (ELSOFT AG)"

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox