From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Tue, 27 Feb 2007 10:48:36 -0600 Subject: [U-Boot-Users] [PATCH] Fix initrd length miscalculation in bootm command In-Reply-To: <20070226131044.890DA352674@atlas.denx.de> References: <20070226131044.890DA352674@atlas.denx.de> Message-ID: <45E460E4.2080004@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <45DB7ED5.5000306@freescale.com> you wrote: >> I can confirm that multi-images work both with and without my patch. So if >> there are no objections, please apply this patch. Thanks. > > Since it doesn't fix a problem I see little reason to change the > code. Wolfgang, I didn't get a response from you about my last email on this thread, so I just want to make sure that you understand that my patch, "Fix initrd length miscalculation in bootm command," does fix a real bug in do_bootm_linux(). Here's the changelog for the patch: "The do_bootm_linux() function was using the same variable ('len') to calculate the the dtu length and the initrd length, which meant that the initrd length was incorrect. This patch creates renames 'len' and 'data' to 'initrd_len' and 'initrd_data', thereby preventing any future confusion. It also deletes 'len' and 'data' because the dtu calculations don't actually need them." The tracking number is DNX#2007020542000011. -- Timur Tabi Linux Kernel Developer @ Freescale