From mboxrd@z Thu Jan 1 00:00:00 1970 From: Txema Lopez Date: Wed, 28 Feb 2007 08:43:38 +0100 Subject: [U-Boot-Users] [PATCH] Support for csb535fs / i.MX21 LiteKit. In-Reply-To: <528646bc0702270920r2b120aa9s2bf234187153d544@mail.gmail.com> References: <45E42BE3.9060305@aotek.es> <528646bc0702270920r2b120aa9s2bf234187153d544@mail.gmail.com> Message-ID: <45E532AA.9030008@aotek.es> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Grant Likely wrote: > On 2/27/07, Txema Lopez wrote: > >> Hi all, >> This patch, for the 1.2.0 version, adds support for the csb535fs board >> embedded in a csb935fs breakout board. The set is known as i.MX21 >> Litekit. > > > With a quick perusal, the patch looks mostly okay. Unfortunately, > it's inconvenient to review because it was sent as a gzipped > attachment instead of inline (I can't just hit 'reply' and start > typing comments). > I'm sorry, the patch size is more than the 40k U-Boot's limit, so ... > Here are some general comments: > - You should add your copyright to all new files that you've added. > At the moment, your copyright only appears on a few of the new files. The cpu/arm926ejs/imx21 files have been copied from the cpu/arm920t/imx with a few modifications, so in the files with minor changes I've left the old copyright. > - Where did include/asm-arm/arch-imx21/imx21-regs.h come from? There > is no copyright notice on it at all. It is a modification of include/asm-arm/arch-imx/imx-regs.h > - There's a fair bit of inconsistent whitespace (intermixed space and > tab characters). Please, could you be more explicit and tell me where these mistakes are . > - I do wonder at the amount of boilerplate required for each new board > port (but that's a longer ranged questions directed at the whole of > u-boot). > Me too. Best regards, -------------- next part -------------- A non-text attachment was scrubbed... Name: tlopez.vcf Type: text/x-vcard Size: 324 bytes Desc: not available Url : http://lists.denx.de/pipermail/u-boot/attachments/20070228/d5bedb08/attachment.vcf