[U-Boot-Users] SATA PATCH

[U-Boot-Users] SATA PATCH

[mushtaq khan]

Be wrote:

This patch will be processed faster if you're able to
get it under 40kB and attach unzipped.  It's currently
40.1kB, so this should be easy for you.

Hi,

Resending the SATA patch with size less than 40kb.

Thanks,
-Mushtaq


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Feature_decription.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070314/691cfdd0/attachment.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Sata.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070314/691cfdd0/attachment-0001.txt 

[U-Boot-Users] SATA PATCH

[Wolfgang Denk]

Dear Mushtaq,

in message <45F7F19A.9030605@procsys.com> you wrote:
> 
> Resending the SATA patch with size less than 40kb.

Thanks. The patch has a few coding style issues: indentation by space
instead of TABs, trailing white space, etc.

Please see http://www.denx.de/wiki/UBoot/CodingStyle

Please insert a few more spaces, i. e. instead of 

	}else if(strcmp(argv[1],"part") == 0){
write:
	} else if (strcmp(argv[1],"part") == 0) {

In a few places your indentation looks random, like here:

	printf ("%ld blocks written: %s\n",
	                                        n, (n==cnt) ? "OK" : "ERROR");

Please use only lower case letters for the command name, i. e. "sata"
instead of "Sata".

In common/Makefile and drivers/Makefile,  please  keep  the  list  of
object file names alphabetically sorted.

Please clean up and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'd like to meet the man who invented sex and see what  he's  working
on now.

[U-Boot-Users] SATA PATCH

[mushtaq khan]

Wolfgang Denk wrote:

> The patch has a few coding style issues: indentation by space
>instead of TABs, trailing white space, etc.
>
>Please see http://www.denx.de/wiki/UBoot/CodingStyle
>
>Please clean up and resubmit.
>
>
>  
>
Hi ,
    I have done the indentation by running the script "Lindent" of linux 
source code with -pcs  option.

Thanks,
-Mushtaq Khan.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sata.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070326/6410ffab/attachment.txt 

[U-Boot-Users] SATA PATCH

[mushtaq khan]

Hi,

I am resending the patch with proper indentation. This patch is for SATA 
controllers of Intel processor with South bridge ICH5,ICH6 and ICH7. 
These chipsets don't support AHCI interface.

Code is divided in to two files. One file has functions which are 
specific to controller and another file which has functions, which are 
common to most of the Sata controllers.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Feature_decription.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20070305/065bdd7c/attachment.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Sata.patch.tar.gz
Type: application/x-gzip
Size: 10538 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070305/065bdd7c/attachment.bin 

[U-Boot-Users] SATA patch.

[mushtaq khan]

Hi,

I have attach a patch, for a SATA controller of Intel processor with 
South Bridge ICH5, ICH6 and ICH7. These chipset's don't support AHCI, 
and so you cann't use the driver ahci.c in u-boot code.
I have divided the code into two files, functions which are controller 
specifc are kept in ata-piix.c under directory drivers(this is with 
reference to ata-piix driver in kernel). And functions which are common 
to Sata controllers are kept in cmd_sata.c, under directory common (this 
is with reference to libata in kernel and cmd_ide.c in u-boot).

Thanks,
Mushtaq khan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.tar.gz
Type: application/x-gzip
Size: 12089 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070222/b193fbae/attachment.bin 

[U-Boot-Users] SATA patch.

[Ben Warren]

Mushtaq,

On Thu, 2007-02-22 at 13:12 +0530, mushtaq khan wrote:
> Hi,
> 
> I have attach a patch, for a SATA controller of Intel processor with 
> South Bridge ICH5, ICH6 and ICH7. These chipset's don't support AHCI, 
> and so you cann't use the driver ahci.c in u-boot code.
> I have divided the code into two files, functions which are controller 
> specifc are kept in ata-piix.c under directory drivers(this is with 
> reference to ata-piix driver in kernel). And functions which are common 
> to Sata controllers are kept in cmd_sata.c, under directory common (this 
> is with reference to libata in kernel and cmd_ide.c in u-boot).
> 
> Thanks,
> Mushtaq khan.

I started reading through this and quickly gave up.  Please address the
following before re-submitting:

1.  General coding standards violations:
	line lengths < 78 characters
	No '#if 0' or '#if 1'
	Keep blank lines to a readable minimum
	No C++ style comments
	blah, blah, blah - read the guidelines

2.  The only files you should send are patches.  The others are
superfluous.  Changelog isn't necessary and the other one should either
be in the e-mail or as a README

3.  Please use a .diff or .patch filename extension.  Text editors often
key syntax highlighting and other things from extensions.

Please read the following.  It will help you format your submission.

http://www.kernel.org/pub/software/scm/git/docs/everyday.html

regards,
Ben