public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix wrong ID for 28F256P30 in flash.h
Date: Thu, 15 Mar 2007 21:57:01 -0500	[thread overview]
Message-ID: <45FA077D.30609@orkun.us> (raw)
In-Reply-To: <20070315082831.05A10352669@atlas.denx.de>

Wolfgang Denk wrote:
> In message <45F8F52B.9000206@orkun.us> you wrote:
>   
>> I personally actually want to remove these macros for any device that 
>> could be serviced by cfi_flash.c driver.
>>     
>
> That would break all custom drivers that use these; and there are
> systems that cannot use the CFI driver because of size restrictions.
>
> Best regards,
>
> Wolfgang Denk
>
>   
Obviously, I would not remove the ones that are in use but I suspect 
there are some that are not in use after switching to cfi_flash.c.

I think for new flash that is cfi compliant and could be serviced by 
cfi_flash.c there is no reason to define these macros.

Whenever I have some time, I actually want to improve cfi_flash.c to 
handle non-cfi flash as well. It will use jedec ids stored in a table so 
these macros would not be much useful.

Best regards,
Tolunay

  reply	other threads:[~2007-03-16  2:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13 17:42 [U-Boot-Users] [PATCH] Fix wrong ID for 28F256P30 in flash.h Pete MacKay
2007-03-15  7:26 ` Tolunay Orkun
2007-03-15  8:28   ` Wolfgang Denk
2007-03-16  2:57     ` Tolunay Orkun [this message]
2007-03-16  9:49       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FA077D.30609@orkun.us \
    --to=listmember@orkun.us \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox