From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tolunay Orkun Date: Thu, 15 Mar 2007 21:57:01 -0500 Subject: [U-Boot-Users] [PATCH] Fix wrong ID for 28F256P30 in flash.h In-Reply-To: <20070315082831.05A10352669@atlas.denx.de> References: <20070315082831.05A10352669@atlas.denx.de> Message-ID: <45FA077D.30609@orkun.us> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <45F8F52B.9000206@orkun.us> you wrote: > >> I personally actually want to remove these macros for any device that >> could be serviced by cfi_flash.c driver. >> > > That would break all custom drivers that use these; and there are > systems that cannot use the CFI driver because of size restrictions. > > Best regards, > > Wolfgang Denk > > Obviously, I would not remove the ones that are in use but I suspect there are some that are not in use after switching to cfi_flash.c. I think for new flash that is cfi compliant and could be serviced by cfi_flash.c there is no reason to define these macros. Whenever I have some time, I actually want to improve cfi_flash.c to handle non-cfi flash as well. It will use jedec ids stored in a table so these macros would not be much useful. Best regards, Tolunay