From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Hobi Date: Tue, 20 Mar 2007 09:56:28 +0100 Subject: [U-Boot-Users] CONFIG_HW_WATCHDOG in 1.1.6 In-Reply-To: <20070320013638.5E92935260B@atlas.denx.de> References: <20070320013638.5E92935260B@atlas.denx.de> Message-ID: <45FFA1BC.2040809@gmx.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 20.03.2007 02:36, Wolfgang Denk wrote: > In message you wrote: >> My examination of the source code has shown that there is no watchdog >> interactions in the tight loop in drivers/ns16550.c:NS16550_getc(). > > Seems you are the first to use this serial driver with a watchdog > turned on... At least the first one using a watchdog model which does not rely on a timer interrupt triggering the (hardware) watchdog. > Watchdig trigger points are missing and should be added to the > driver. I'm looking forward to seeing your patch... What's the preferred policy to trigger the watchdog in U-Boot? Trigger using a timer interrupt (as in lib_ppc/interrupts.c) or add calls to WATCHDOG_RESET() to every function which may take longer than some fraction of the minimal watchdog period (which is?)? I know there are functions which disable interrupts and thus have to trigger the watchdog themself (like do_bootm). Best Regards, Daniel