Re: [PATCH 01/10] dt-bindings: i3c: Add YAML schema for Cadence I3C controller

[Michal Simek <michal.simek@amd.com>]

On 2/18/25 03:56, dinesh.maniyam@intel.com wrote:
> From: Dinesh Maniyam <dinesh.maniyam@intel.com>
> 
> Add a YAML device tree binding schema for the Cadence I3C controller,
> defining required and optional properties for proper integration
> and validation with dt-schema.
> 
> Signed-off-by: Dinesh Maniyam <dinesh.maniyam@intel.com>
> ---
>   .../i3c/cdns,i3c-master.yaml                  |  51 +++++
>   doc/device-tree-bindings/i3c/i3c.yaml         | 186 ++++++++++++++++++
>   2 files changed, 237 insertions(+)
>   create mode 100644 doc/device-tree-bindings/i3c/cdns,i3c-master.yaml
>   create mode 100644 doc/device-tree-bindings/i3c/i3c.yaml
> 
> diff --git a/doc/device-tree-bindings/i3c/cdns,i3c-master.yaml b/doc/device-tree-bindings/i3c/cdns,i3c-master.yaml
> new file mode 100644
> index 0000000000..0eda16482e
> --- /dev/null
> +++ b/doc/device-tree-bindings/i3c/cdns,i3c-master.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/cdns,i3c-master.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cadence I3C master block
> +
> +maintainers:
> +  - Dinesh Maniyam <dinesh.maniyam@intel.com>
> +
> +allOf:
> +  - $ref: i3c.yaml#
> +
> +properties:
> +  compatible:
> +    const: snps,dw-i3c-master-1.00a


Filename is not fitting with compatible string used here.
Anyway binding is already in the linux kernel that's why you don't need to put 
it here.
Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml

M