public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Testing todays u-boot-fdt
Date: Thu, 19 Apr 2007 15:42:53 +0200	[thread overview]
Message-ID: <462771DD.9070706@grandegger.com> (raw)
In-Reply-To: <46276E94.6090204@smiths-aerospace.com>

Jerry Van Baren wrote:
> Wolfgang Grandegger wrote:
>> Hi Jerry,
>>
>> I gave the fdtlib of your git://cideas.us/pub/scm/u-boot/u-boot-fdt.git
>> a try on my Icecube board. I got it built with the attached patch. 
>> libfdt was actually not made and the second hunk fixes a warning 
>> (=bug?). Then I was able to read and list a blob in memory:
> 
> [snip]
> 
>> diff --git a/Makefile b/Makefile
>> index 9a27bc2..94cda54 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -219,6 +219,7 @@ LIBS += $(shell if [ -d post/cpu/$(CPU) ]; then 
>> echo \
>>  LIBS += $(shell if [ -d post/board/$(BOARDDIR) ]; then echo \
>>      "post/board/$(BOARDDIR)/libpost$(BOARD).a"; fi)
>>  LIBS += common/libcommon.a
>> +LIBS += libfdt/libfdt.a
>>  LIBS += $(BOARDLIBS)
>>  
>>  LIBS := $(addprefix $(obj),$(LIBS))
> 
> Ahh, that is not a bug, you fixed the wrong file.  You need to add 
> libfdt/libfdt.a to your board's BOARDLIBS in your board's config file 
> (see line after your addition - been there, did the same thing ;-). 
> There is no point building libfdt.a if it isn't used.

Ah, I was already wondering why it did work on your side. Nevertheless,
touching two places to use the library is cumbersome. But adding ifdef's 
to the source code is also not nice.

Wolfgang.

  reply	other threads:[~2007-04-19 13:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-19  8:58 [U-Boot-Users] Testing todays u-boot-fdt Wolfgang Grandegger
2007-04-19 12:08 ` Jerry Van Baren
2007-04-19 13:10   ` Wolfgang Grandegger
2007-04-19 13:19     ` Jerry Van Baren
2007-04-19 15:24   ` Timur Tabi
2007-04-22 20:38   ` Timur Tabi
2007-04-23  0:05     ` Jerry Van Baren
2007-04-19 13:28 ` Jerry Van Baren
2007-04-19 13:42   ` Wolfgang Grandegger [this message]
2007-04-19 15:51   ` Wolfgang Denk
2007-04-19 23:11     ` Jerry Van Baren
2007-04-19 23:19       ` Wolfgang Denk
2007-04-20 16:36       ` Wolfgang Grandegger
2007-04-20 17:11         ` Jerry Van Baren
2007-04-20 20:40           ` Wolfgang Denk
2007-04-20 22:02             ` Jerry Van Baren
2007-04-20  3:38 ` Jerry Van Baren
2007-04-20 13:32   ` Wolfgang Denk
2007-04-20  3:40 ` Jerry Van Baren
     [not found] <4629358C.5050401@cideas.com>
2007-04-20 23:01 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462771DD.9070706@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox