From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Thu, 19 Apr 2007 15:42:53 +0200
Subject: [U-Boot-Users] Testing todays u-boot-fdt
In-Reply-To: <46276E94.6090204@smiths-aerospace.com>
References: <46272F29.7020001@grandegger.com>
	<46276E94.6090204@smiths-aerospace.com>
Message-ID: <462771DD.9070706@grandegger.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jerry Van Baren wrote:
> Wolfgang Grandegger wrote:
>> Hi Jerry,
>>
>> I gave the fdtlib of your git://cideas.us/pub/scm/u-boot/u-boot-fdt.git
>> a try on my Icecube board. I got it built with the attached patch. 
>> libfdt was actually not made and the second hunk fixes a warning 
>> (=bug?). Then I was able to read and list a blob in memory:
> 
> [snip]
> 
>> diff --git a/Makefile b/Makefile
>> index 9a27bc2..94cda54 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -219,6 +219,7 @@ LIBS += $(shell if [ -d post/cpu/$(CPU) ]; then 
>> echo \
>>  LIBS += $(shell if [ -d post/board/$(BOARDDIR) ]; then echo \
>>      "post/board/$(BOARDDIR)/libpost$(BOARD).a"; fi)
>>  LIBS += common/libcommon.a
>> +LIBS += libfdt/libfdt.a
>>  LIBS += $(BOARDLIBS)
>>  
>>  LIBS := $(addprefix $(obj),$(LIBS))
> 
> Ahh, that is not a bug, you fixed the wrong file.  You need to add 
> libfdt/libfdt.a to your board's BOARDLIBS in your board's config file 
> (see line after your addition - been there, did the same thing ;-). 
> There is no point building libfdt.a if it isn't used.

Ah, I was already wondering why it did work on your side. Nevertheless,
touching two places to use the library is cumbersome. But adding ifdef's 
to the source code is also not nice.

Wolfgang.