public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <vanbaren@cideas.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Testing todays u-boot-fdt
Date: Fri, 20 Apr 2007 18:02:22 -0400	[thread overview]
Message-ID: <4629386E.3030508@cideas.com> (raw)
In-Reply-To: <20070420204025.DB57A352650@atlas.denx.de>

Wolfgang Denk wrote:
> In message <4628F431.1020901@smiths-aerospace.com> you wrote:
>> At this point I'm reluctant to do this.  We've basically forked libfdt 
> 
> I perfectly understand your reluctance. It's ugly, and a poor  worka-
> round  for  a  problem that should besolved differently (i. e. by not
> compiling unneeded files at all).
> 
> If you want to do it  right,  it  comes  down  to  a  rework  of  the
> configuration  and  build system. As much as I would like to see work
> being done on this, as much I am also aware that we  have  even  more
> urgent tasks to solve at the moment (like getting the delays in patch
> processing down).
> 
>> Adding the above to all of the files makes it that much more u-boot 
>> specific which will make it that much more difficult to unfork.  On the 
>> other hand, it is "only" three lines per file.
>>
>> Anyone care to weigh in on the issue?  wd?
> 
> It's just 6 files, and the changes are trivial to  do  and  to  undo.
> Since Wolfgang G. already spent the effort to implement it, I suggect
> to add this. If we want to get rid of this later, a simple "patch -R"
> will probably be all that's needed.
> 
> Best regards,
> Wolfgang Denk

Hi Wolfgang,

...and there's the irony.  With it as a library included by BOARDLIBS in
the board config file, it is only compiled if it is called for in the
board's config.mk.

It seems like it would be overall a win to have more of a real library
approach.  I have not gone down that path hardly at all, however, and it
is likely to have briers that I'm not aware of.  It also would take
time.  :-/

Having said that, I don't have any real issue in applying wg's patch.
It isn't a big deal and will match the rest of u-boot methodology.  At
the end of the day, it is a lot easier than converting everything to
true libraries. ;-]

Best regards,
gvb

  reply	other threads:[~2007-04-20 22:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-19  8:58 [U-Boot-Users] Testing todays u-boot-fdt Wolfgang Grandegger
2007-04-19 12:08 ` Jerry Van Baren
2007-04-19 13:10   ` Wolfgang Grandegger
2007-04-19 13:19     ` Jerry Van Baren
2007-04-19 15:24   ` Timur Tabi
2007-04-22 20:38   ` Timur Tabi
2007-04-23  0:05     ` Jerry Van Baren
2007-04-19 13:28 ` Jerry Van Baren
2007-04-19 13:42   ` Wolfgang Grandegger
2007-04-19 15:51   ` Wolfgang Denk
2007-04-19 23:11     ` Jerry Van Baren
2007-04-19 23:19       ` Wolfgang Denk
2007-04-20 16:36       ` Wolfgang Grandegger
2007-04-20 17:11         ` Jerry Van Baren
2007-04-20 20:40           ` Wolfgang Denk
2007-04-20 22:02             ` Jerry Van Baren [this message]
2007-04-20  3:38 ` Jerry Van Baren
2007-04-20 13:32   ` Wolfgang Denk
2007-04-20  3:40 ` Jerry Van Baren
     [not found] <4629358C.5050401@cideas.com>
2007-04-20 23:01 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4629386E.3030508@cideas.com \
    --to=vanbaren@cideas.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox