From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 23 Apr 2007 17:22:54 +0400 Subject: [U-Boot-Users] [Ticket#2007011742000232] [PATCH] Avoid assigning PCI resources from zero ad [...] In-Reply-To: <1169049681.381595.382224316@castor.denx.de> References: <1169049681.381595.382224316@castor.denx.de> Message-ID: <462CB32E.3010309@ru.mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. OTRS Notification Master wrote: > inside the automatic U-Boot patch tracking system a new ticket > [DNX#2007011742000232] was created: > >>If a PCI IDE card happens to get a zero address assigned to it, the >>Linux IDE >>core complains and IDE drivers fails to work. Also, assigning zero to a >>BAR >>was illegal according to PCI 2.1 (the later revisions seem to have >>excluded the >>sentence about "0" being considered an invalid address) -- so, use a >>reasonable >>starting value of 0x1000 (that's what the most Linux archs are using). >> >>Alternatively, one might have fixed the calls to pci_set_region() >>individually >>(some code even seems to have taken care of this issue) but that would >>have >>been a lot more work. :-) >> >>Signed-off-by: Sergei Shtylyov >> >> drivers/pci_auto.c | 7 ++++++- >> 1 files changed, 6 insertions(+), 1 deletion(-) >> >>Index: u-boot/drivers/pci_auto.c >>=================================================================== >>--- u-boot.orig/drivers/pci_auto.c >>+++ u-boot/drivers/pci_auto.c >>@@ -34,7 +34,12 @@ >> >> void pciauto_region_init(struct pci_region* res) >> { >>- res->bus_lower = res->bus_start; >>+ /* >>+ * Avoid allocating PCI resources from address 0 -- this is illegal >>+ * according to PCI 2.1 and moreover, this is known to cause Linux IDE >>+ * drivers to fail. Use a reasonable starting value of 0x1000 instead. >>+ */ >>+ res->bus_lower = res->bus_start ? res->bus_start : 0x1000; >> } >> >> void pciauto_region_align(struct pci_region *res, unsigned long size) I wonder if this patch has ever been considered... WBR, Sergei