From: Michal Simek <michal.simek@amd.com>
To: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>,
<u-boot@lists.denx.de>
Cc: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>,
Michal Simek <michal.simek@xilinx.com>,
Jorge Ramirez-Ortiz <jorge@foundries.io>,
Ricardo Salveti <ricardo@foundries.io>,
Igor Opaniuk <igor.opaniuk@foundries.io>
Subject: Re: [PATCH v11 10/13] fpga: zynqmp: optimize zynqmppl_load() code
Date: Fri, 8 Jul 2022 14:43:07 +0200 [thread overview]
Message-ID: <46380a1d-752f-e03e-3fde-80d0496d469a@amd.com> (raw)
In-Reply-To: <20220705192320.415861-11-oleksandr.suvorov@foundries.io>
On 7/5/22 21:23, Oleksandr Suvorov wrote:
> Optimize function code preparing to add secure bitstream types
> support.
Can you please extend this? I understand what you do below but better
description will be good.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> Tested-by: Ricardo Salveti <ricardo@foundries.io>
> Tested-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
> ---
>
> (no changes since v1)
>
> drivers/fpga/zynqmppl.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/fpga/zynqmppl.c b/drivers/fpga/zynqmppl.c
> index 239c498f7b5..6959b8ae97e 100644
> --- a/drivers/fpga/zynqmppl.c
> +++ b/drivers/fpga/zynqmppl.c
> @@ -199,46 +199,45 @@ static int zynqmp_validate_bitstream(xilinx_desc *desc, const void *buf,
> return 0;
> }
>
> -static int zynqmp_load(xilinx_desc *desc, const void *buf, size_t bsize,
> - bitstream_type bstype, int flags)
> +static int zynqmp_load(xilinx_desc *desc, const void *buf,
> + size_t bsize, bitstream_type bstype,
> + int flags)
This is unrelated to commit. This is purely coding style change.
> {
> ALLOC_CACHE_ALIGN_BUFFER(u32, bsizeptr, 1);
> u32 swap = 0;
> ulong bin_buf;
> int ret;
> u32 buf_lo, buf_hi;
> + u32 bsize_req = (u32)bsize;
> u32 ret_payload[PAYLOAD_ARG_CNT];
> - bool xilfpga_old = false;
> +
> + debug("%s called!\n", __func__);
>
> if (zynqmp_firmware_version() <= PMUFW_V1_0) {
> puts("WARN: PMUFW v1.0 or less is detected\n");
> puts("WARN: Not all bitstream formats are supported\n");
> puts("WARN: Please upgrade PMUFW\n");
> - xilfpga_old = true;
> - if (zynqmp_validate_bitstream(desc, buf, bsize, bsize, &swap))
> + if (zynqmp_validate_bitstream(desc, buf, bsize,
> + bsize, &swap))
This is also coding style change only.
> return FPGA_FAIL;
> bsizeptr = (u32 *)&bsize;
> flush_dcache_range((ulong)bsizeptr,
> (ulong)bsizeptr + sizeof(size_t));
> + bsize_req = (u32)(uintptr_t)bsizeptr;
> bstype |= BIT(ZYNQMP_FPGA_BIT_NS);
> + } else {
> + bstype = 0;
> }
>
> bin_buf = zynqmp_align_dma_buffer((u32 *)buf, bsize, swap);
>
> - debug("%s called!\n", __func__);
nit: And this also has nothing to do with optimization. You just changed location.
> flush_dcache_range(bin_buf, bin_buf + bsize);
>
> buf_lo = (u32)bin_buf;
> buf_hi = upper_32_bits(bin_buf);
>
> - if (xilfpga_old)
> - ret = xilinx_pm_request(PM_FPGA_LOAD, buf_lo,
> - buf_hi, (u32)(uintptr_t)bsizeptr,
> - bstype, ret_payload);
> - else
> - ret = xilinx_pm_request(PM_FPGA_LOAD, buf_lo,
> - buf_hi, (u32)bsize, 0, ret_payload);
> -
> + ret = xilinx_pm_request(PM_FPGA_LOAD, buf_lo, buf_hi,
> + bsize_req, bstype, ret_payload);
> if (ret)
> printf("PL FPGA LOAD failed with err: 0x%08x\n", ret);
>
M
next prev parent reply other threads:[~2022-07-08 12:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 19:23 [PATCH v11 00/13] fpga: zynqmp: Adding support of loading authenticated images Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 01/13] fpga: add option for loading FPGA secure bitstreams Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 02/13] fpga: xilinx: add missed identifier names Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 03/13] fpga: xilinx: add bitstream flags to driver desc Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 04/13] fpga: zynqmp: add str2flags call Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 05/13] fpga: add fpga_compatible2flag Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 06/13] fpga: xilinx: pass compatible flags to xilinx_load() Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 07/13] fpga: pass compatible flags to fpga_load() Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 08/13] spl: fit: pass real " Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 09/13] fpga: xilinx: pass compatible flags to load() callback Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 10/13] fpga: zynqmp: optimize zynqmppl_load() code Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 11/13] fpga: zynqmp: add bitstream compatible checking Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 12/13] fpga: zynqmp: support loading authenticated images Oleksandr Suvorov
2022-07-05 19:23 ` [PATCH v11 13/13] fpga: zynqmp: support loading encrypted bitfiles Oleksandr Suvorov
2022-07-08 12:43 ` Michal Simek [this message]
2022-07-08 13:15 ` [PATCH v11 10/13] fpga: zynqmp: optimize zynqmppl_load() code Oleksandr Suvorov
2022-07-08 13:35 ` Michal Simek
2022-07-08 12:40 ` [PATCH v11 08/13] spl: fit: pass real compatible flags to fpga_load() Michal Simek
2022-07-12 10:58 ` [PATCH v11 01/13] fpga: add option for loading FPGA secure bitstreams Simon Glass
2022-07-12 11:45 ` Michal Simek
2022-07-08 12:45 ` [PATCH v11 00/13] fpga: zynqmp: Adding support of loading authenticated images Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46380a1d-752f-e03e-3fde-80d0496d469a@amd.com \
--to=michal.simek@amd.com \
--cc=adrian.fiergolski@fastree3d.com \
--cc=igor.opaniuk@foundries.io \
--cc=jorge@foundries.io \
--cc=michal.simek@xilinx.com \
--cc=oleksandr.suvorov@foundries.io \
--cc=ricardo@foundries.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox