From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info
Date: Thu, 03 May 2007 16:06:16 -0500 [thread overview]
Message-ID: <463A4EC8.9080301@orkun.us> (raw)
In-Reply-To: <20070503100453.GA5146@michl.2n.cz>
Ladislav Michl wrote:
> On Wed, May 02, 2007 at 04:50:48PM -0500, Tolunay Orkun wrote:
>> I looked at your patch when you submitted but did not carefully review
>> yet. I feel like the function should reside inside the flash driver
>> where it is most often used and flash driver should export it.
>
> I disagree. This function (addr2info) is used also by board specific
> drivers as well as by common/cmd_load.c, common/cmd_bootm.c and
> common/cmd_mem.c. Therefore it should reside in common/flash.c - to
> be used by either board specific driver or cfi driver.
>
> Best regards,
> ladis
Landis,
I was referring to the frequency of the use of the function during flash
programming. I am use it is called elsewhere but when the function is in
the same file compiler has more opportunities to optimize. That is why I
prefer the function stay in the flash driver and exported from there.
Tolunay
next prev parent reply other threads:[~2007-05-03 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 11:52 [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info Ladislav Michl
2007-03-24 18:27 ` [U-Boot-Users] u-boot.lds Charles Krinke
2007-03-25 20:38 ` Wolfgang Denk
2007-04-24 10:26 ` [U-Boot-Users] [PATCH] cfi_flash.c: use addr2info Ladislav Michl
2007-05-02 21:50 ` Tolunay Orkun
2007-05-03 10:04 ` Ladislav Michl
2007-05-03 21:06 ` Tolunay Orkun [this message]
2007-05-16 10:27 ` Ladislav Michl
2007-05-16 10:45 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463A4EC8.9080301@orkun.us \
--to=listmember@orkun.us \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox